Bug 251487 - games/neverball: fix build with -fno-common
Summary: games/neverball: fix build with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-30 15:21 UTC by Greg V
Modified: 2020-12-02 14:33 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
neverball-common.patch (1.58 KB, patch)
2020-11-30 15:21 UTC, Greg V
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg V 2020-11-30 15:21:25 UTC
Created attachment 220106 [details]
neverball-common.patch

ld: error: duplicate symbol: text_input
>>> defined at text.c
>>>            share/text.o:(text_input)
>>> defined at st_save.c
>>>            ball/st_save.o:(.bss+0x10)

ld: error: duplicate symbol: text_input
>>> defined at text.c
>>>            share/text.o:(text_input)
>>> defined at st_name.c
>>>            ball/st_name.o:(.bss+0x20)

ld: error: duplicate symbol: text_input
>>> defined at text.c
>>>            share/text.o:(text_input)
>>> defined at main.c
>>>            ball/main.o:(.bss+0x1080)

Let's just add -fcommon for now I guess
Comment 1 commit-hook freebsd_committer 2020-12-02 14:20:57 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Dec  2 14:20:53 UTC 2020
New revision: 556825
URL: https://svnweb.freebsd.org/changeset/ports/556825

Log:
  - Fix build with -fno-common

  PR:		251487
  Submitted by:	greg@unrelenting.technology

Changes:
  head/games/neverball/Makefile