Created attachment 220154 [details] Patch (Revision 1) Passes poudriere
Created attachment 220156 [details] Patch (Revision 2) Forgot a few things.
Created attachment 220162 [details] Additional improvements in port Makefile Hi Neel, I updated the Makefile so it conforms to the order of the variables in the Handbook (https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-order) Having a look at the changes in pkg-plist. Did you check that the package builds correctly with DEBUG=ON and DEBUG=OFF?
Yep, it does not build with DEBUG=ON ====> Compressing man pages (compress-man) =========================================================================== ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: bin/ns%%VERSION%%-adaptive-red-tests%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-adhoc-aloha-ideal-phy%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-adhoc-aloha-ideal-phy-matrix-propagation-loss-model%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-adhoc-aloha-ideal-phy-with-microwave-oven%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-aodv%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-basic-energy-model-test%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-bench-packets%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-bench-simulator%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-bonnmotion-ns2-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-buildings-pathloss-profiler%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-cobalt-vs-codel%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-codel-vs-pfifo-asymmetric%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-codel-vs-pfifo-basic-test%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-colors-link-description%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-command-line-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-config-store-save%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-bridge%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-bridge-one-hop%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-broadcast%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-multicast%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-one-subnet%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-packet-socket%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-ping%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-raw-ip-socket%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-csma-star%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-dctcp-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-dhcp-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-double-probe-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-dsdv-manet%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-dsr%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-dumbbell-animation%%DEBUG_SUFX%% ... ...
Created attachment 220178 [details] Patch (Revision 3) Here I hopefully added debug
(In reply to Neel Chauhan from comment #4) We are not there yet :S You mentioned revision 3 in the patch, but it is actually named ns3-3.32-r2.diff. Did you upload the last one?
This is the correct one. r2 is because it's MY second one (on my local system), but I said Revision 3 here because of your second patch (which my Revision 3) is based on.
To clarify, my patch is "Revision 3" because I'll assume r2 is your patch.
Sorry of the confusion on revision numbers, could someone please commit this patch?
(In reply to Neel Chauhan from comment #8) As I said in comment #5 we are not quite there. It still fails with DEBUG=on ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: bin/ns%%VERSION%%-dynamic-global-routing%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-empirical-random-variable-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-energy-model-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-energy-model-with-harvesting-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-example-ping-lr-wpan-beacon%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-example-ping-lr-wpan%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-example-ping-lr-wpan-mesh-under%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-example-sixlowpan%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-fatal-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-fifth%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-file-aggregator-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-file-helper-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-first%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-fourth%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-fqcodel-l4s-example%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-fragmentation-ipv6%%DEBUG_SUFX%% Error: Orphaned: bin/ns%%VERSION%%-fragmentation-ipv6-two-MTU%%DEBUG_SUFX%% ... ...
Created attachment 220440 [details] Patch (Revision 4) Try this.
A commit references this bug: Author: fernape Date: Fri Dec 11 11:27:39 UTC 2020 New revision: 557722 URL: https://svnweb.freebsd.org/changeset/ports/557722 Log: net/ns3: Update to 3.32 & set MAINTAINER Submitter becomes MAINTAINER. Already maintainer of several ports. PR: 251518 Submitted by: neel@neelc.org Changes: head/net/ns3/Makefile head/net/ns3/distinfo head/net/ns3/pkg-plist
Committed! Thank you for all the changes and for taking maintainerhsip!