Bug 251538 - New port: chinese/ibus-array Array 30 Traditional Chinese IME module for ibus
Summary: New port: chinese/ibus-array Array 30 Traditional Chinese IME module for ibus
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-02 17:36 UTC by Jia-Shiun Li
Modified: 2023-11-08 08:04 UTC (History)
1 user (show)

See Also:


Attachments
ports archive of ibus-array to be placed under chinese category. (1.95 KB, text/plain)
2020-12-02 17:36 UTC, Jia-Shiun Li
no flags Details
Create chinese/ibus-array (3.34 KB, patch)
2023-10-10 16:52 UTC, Jia-Shiun Li
no flags Details | Diff
Create chinese/ibus-array (3.38 KB, patch)
2023-11-05 04:12 UTC, Jia-Shiun Li
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia-Shiun Li 2020-12-02 17:36:21 UTC
Created attachment 220180 [details]
ports archive of ibus-array to be placed under chinese category.

Actually resurrect chinese/ibus-array deprecated due to Python 2.7 dependency.

The attached patch updates ibus-array to the latest version which uses python3.
Comment 1 Jia-Shiun Li 2020-12-09 10:40:16 UTC
poudriere tested w/ head & 12-2-R jail
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-09 14:05:35 UTC
(In reply to Jia-Shiun Li from comment #1)
Isn't this covered by chinese/ibus-table-chinese ?
Comment 3 Jia-Shiun Li 2023-08-20 17:32:53 UTC
(In reply to Fernando Apesteguía from comment #2)
ibus-table-chinese does not cover all the neat features defined in Array IME. Shortcut codes, symbols, etc.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-21 07:07:02 UTC
Understood.

Could you?

* Send a patch in gitdiff format
* Remove the $FreeBSD$ line which is deprecated
* Use portlint and or portclippy to lint the port

Thanks.
Comment 5 Jia-Shiun Li 2023-10-10 16:52:29 UTC
Created attachment 245551 [details]
Create chinese/ibus-array

- Update to gitdiff format
- Pick post- v2.2 commit SHA to prevent crash
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-10-11 06:24:10 UTC
(In reply to Jia-Shiun Li from comment #5)
The NLS option uses gettext, but gettext is USEd unconditionally earlier.
Also, could you sort the variables in their proper order? Have a look at https://docs.freebsd.org/en/books/porters-handbook/order/

Thanks!
Comment 7 Jia-Shiun Li 2023-11-05 04:12:27 UTC
Created attachment 246134 [details]
Create chinese/ibus-array

Changes from previous version:
- Remove gettext from USES
- Move GNU_CONFIGURE line order
- Add NLS file to plist
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-11-08 08:04:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90fd687e394c7a8ad9dd38eb0404c378a50b0d5b

commit 90fd687e394c7a8ad9dd38eb0404c378a50b0d5b
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-11-06 11:55:39 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-11-08 08:03:43 +0000

    chinese/ibus-array: new port: IME modules for ibus

    Array 30 Traditional Chinese IME module for ibus

    PR:             251538
    Reported by:    Jia-Shiun Li <jiashiun@gmail.com>

 chinese/Makefile                   |  1 +
 chinese/ibus-array/Makefile (new)  | 32 ++++++++++++++++++++++++++++++++
 chinese/ibus-array/distinfo (new)  |  3 +++
 chinese/ibus-array/pkg-descr (new) |  2 ++
 chinese/ibus-array/pkg-plist (new) | 12 ++++++++++++
 5 files changed, 50 insertions(+)
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2023-11-08 08:04:35 UTC
Committed,

Thanks!