Bug 251545 - [new ports] devel/py-jbxapi and devel/py-pyzipper
Summary: [new ports] devel/py-jbxapi and devel/py-pyzipper
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-02 21:33 UTC by gettoknowmi
Modified: 2021-05-26 13:36 UTC (History)
2 users (show)

See Also:


Attachments
Makefile pyzipper (457 bytes, text/plain)
2020-12-02 21:34 UTC, gettoknowmi
no flags Details
distinfo pyzipper (159 bytes, text/plain)
2020-12-02 21:35 UTC, gettoknowmi
no flags Details
pkg-descr pyzipper (232 bytes, text/plain)
2020-12-02 21:35 UTC, gettoknowmi
no flags Details
Makefile jbxapi (563 bytes, text/plain)
2020-12-02 21:36 UTC, gettoknowmi
no flags Details
distinfo jbxapi (220 bytes, text/plain)
2020-12-02 21:36 UTC, gettoknowmi
no flags Details
pkg-descr jbxapi (232 bytes, text/plain)
2020-12-02 21:37 UTC, gettoknowmi
no flags Details
JBXAPI shar file - The Joe Sandbox API Wrapper enables you to fully integrate Joe Sandbox into your malware analysis framework (1.36 KB, application/x-shellscript)
2020-12-03 14:11 UTC, gettoknowmi
no flags Details
PYZIPPER - A 100% API compatible replacement for Python’s zipfile that can read and write AES encrypted zip files. (1.21 KB, application/x-shellscript)
2020-12-03 14:13 UTC, gettoknowmi
no flags Details
py-pyzipper shar file attached (1.11 KB, application/x-shellscript)
2021-05-21 18:23 UTC, gettoknowmi
no flags Details
py-pyzipper port (1.11 KB, application/x-shellscript)
2021-05-24 15:58 UTC, gettoknowmi
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description gettoknowmi 2020-12-02 21:33:47 UTC
Need further assistance in adding 2 ports to freebsd port tree

tested port locally and both works. figure it be good to have it somewhere in the ports tree as well.


https://pypi.org/project/pyzipper/

https://pypi.org/project/jbxapi/

Thanks.
Comment 1 gettoknowmi 2020-12-02 21:34:34 UTC
Created attachment 220185 [details]
Makefile pyzipper
Comment 2 gettoknowmi 2020-12-02 21:35:09 UTC
Created attachment 220187 [details]
distinfo pyzipper
Comment 3 gettoknowmi 2020-12-02 21:35:33 UTC
Created attachment 220188 [details]
pkg-descr pyzipper
Comment 4 gettoknowmi 2020-12-02 21:36:01 UTC
Created attachment 220189 [details]
Makefile jbxapi
Comment 5 gettoknowmi 2020-12-02 21:36:24 UTC
Created attachment 220190 [details]
distinfo jbxapi
Comment 6 gettoknowmi 2020-12-02 21:37:37 UTC
Created attachment 220191 [details]
pkg-descr jbxapi
Comment 7 Fernando Apesteguía freebsd_committer 2020-12-03 09:38:40 UTC
Hi there,

For new ports, the preferred way is using a shar file. See https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-submitting-shar

Also, it would be better if there was one PR for port.

Last but not least, a nice description of what the ports do and why it is good to have them in the tree would be great :-)

Thanks!
Comment 8 gettoknowmi 2020-12-03 13:13:01 UTC
Thanks for the information. i will keep this in mind moving forward.
do i need to make these changes now or we can still proceed with this.
Comment 9 Dan Langille freebsd_committer 2020-12-03 13:37:19 UTC
Yes, please make the shar file.
Comment 10 gettoknowmi 2020-12-03 14:11:37 UTC
Created attachment 220217 [details]
JBXAPI shar file  - The Joe Sandbox API Wrapper enables you to fully integrate Joe Sandbox into your malware analysis framework

The Joe Sandbox API Wrapper enables you to fully integrate Joe Sandbox
into your malware analysis framework
Comment 11 gettoknowmi 2020-12-03 14:13:21 UTC
Created attachment 220218 [details]
PYZIPPER - A 100% API compatible replacement for Python’s zipfile that can read and write AES encrypted zip files.

A 100% API compatible replacement for Python’s zipfile that can read and write AES encrypted zip files.
Comment 12 Dan Langille freebsd_committer 2020-12-07 20:32:08 UTC
We have discussed some of this offline:

* latest release of pyzipper is 0.3.3
* "USES= python" needs to be "USES= python:3.4+"
* some versions are needed for RUN_DEPENDS
Comment 13 Dan Langille freebsd_committer 2021-01-14 02:18:47 UTC
waiting for new patches.
Comment 14 Dan Langille freebsd_committer 2021-02-26 12:52:57 UTC
I'm patient.
Comment 15 gettoknowmi 2021-05-21 18:23:22 UTC
Created attachment 225157 [details]
py-pyzipper shar file attached
Comment 16 Dan Langille freebsd_committer 2021-05-24 13:20:55 UTC
The latest py-pyzipper fails to build:

[00:00:02] Error: devel/py-pyzipper has incorrect CATEGORIES, first should be 'devel'.  Please contact maintainer of the port to fix this.

The PR says this should be in the devel category.  One of these needs to be corrrected.
Comment 17 Dan Langille freebsd_committer 2021-05-24 13:27:13 UTC
FYI, for future reference, it is probably easiest if you create one PR per port

I suggest creating a new ticket for devel/py-jbxapi because:

* the shar file for devel/py-jbxapi contains a RUN_DEPENDS which refers to py-pyzipper in a category which does not exist in the FreeBSD ports tree.
Comment 18 gettoknowmi 2021-05-24 15:58:08 UTC
Created attachment 225227 [details]
py-pyzipper port
Comment 19 gettoknowmi 2021-05-24 16:00:28 UTC
added new attachment with category fix

i will also create a new PR for jbxapi port
Comment 20 commit-hook freebsd_committer 2021-05-26 13:34:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d20cc22412b52cafffe715fe779449877fcb73a0

commit d20cc22412b52cafffe715fe779449877fcb73a0
Author:     Dan Langille <dvl@FreeBSD.org>
AuthorDate: 2021-05-26 13:27:55 +0000
Commit:     Dan Langille <dvl@FreeBSD.org>
CommitDate: 2021-05-26 13:33:40 +0000

    devel/py-pyzipper: new port for reading/writing AES encrypted zip files

    PR:             251545
    Reported by:    gettoknowmi <gettoknowmi@yahoo.com>

 devel/Makefile                    |  1 +
 devel/py-pyzipper/Makefile (new)  | 19 +++++++++++++++++++
 devel/py-pyzipper/distinfo (new)  |  3 +++
 devel/py-pyzipper/pkg-descr (new) |  4 ++++
 4 files changed, 27 insertions(+)
Comment 21 Dan Langille freebsd_committer 2021-05-26 13:35:20 UTC
Comitted.  Thank you.