Bug 251574 - [NEW PORT] games/sowon: Graphical countdown timer application
Summary: [NEW PORT] games/sowon: Graphical countdown timer application
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-04 07:46 UTC by Nico Sonack
Modified: 2020-12-17 21:30 UTC (History)
2 users (show)

See Also:


Attachments
Patchfile for the port (2.41 KB, patch)
2020-12-04 07:46 UTC, Nico Sonack
no flags Details | Diff
Patch with requested changes (2.40 KB, patch)
2020-12-06 10:00 UTC, Nico Sonack
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Sonack 2020-12-04 07:46:14 UTC
Created attachment 220237 [details]
Patchfile for the port
Comment 1 daniel.engberg.lists 2020-12-04 22:22:57 UTC
Quick review,

Where's the reference to 1.0.0?
Example 5.13. is probably what you're looking for in Porter's handbook.

Remove MASTER_SITES
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description

Games seems a bit odd as category, deskutils seems like a better choice?

Does it pass portlint? 
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#testing-portlint

Is port tested using Poudriere?

Best regards,
Daniel
Comment 2 Nico Sonack 2020-12-05 17:32:39 UTC
(In reply to daniel.engberg.lists from comment #1)

> Where's the reference to 1.0.0?
> Example 5.13. is probably what you're looking for in Porter's handbook.

Thank you for the reference to the Porter's handbook. Indeed I haven't seen that example.
On the 1.0.0 version number: That was decided upon in a private conversation. Since that is not official, I agree on changing it to the commit date.

> Games seems a bit odd as category, deskutils seems like a better choice?

Yes. It definitely is.

> Does it pass portlint? 

Yes. I specifically tested it against portlint.

> Is port tested using Poudriere?

No. I am going do that.

Thank you for the review. I'm gonna fix the issues you've mentioned and update the patch.

Best regards,
Nico
Comment 3 Nico Sonack 2020-12-06 10:00:02 UTC
Created attachment 220304 [details]
Patch with requested changes

- Tested with poudriere (12.2 RELEASE amd64)
- Checked against portlint -A and portfmt
Comment 4 daniel.engberg.lists 2020-12-09 22:23:55 UTC
Compile tested on FreeBSD 13.0-CURRENT #0 r367711 (amd64)
Comment 5 commit-hook freebsd_committer 2020-12-17 21:03:51 UTC
A commit references this bug:

Author: makc
Date: Thu Dec 17 21:03:16 UTC 2020
New revision: 558328
URL: https://svnweb.freebsd.org/changeset/ports/558328

Log:
  Add new port deskutils/sowon:

  Graphical countdown and timer application.

  PR:		251574
  Submitted by:	Nico Sonack

Changes:
  head/deskutils/Makefile
  head/deskutils/sowon/
  head/deskutils/sowon/Makefile
  head/deskutils/sowon/distinfo
  head/deskutils/sowon/pkg-descr
Comment 6 Max Brazhnikov freebsd_committer 2020-12-17 21:30:45 UTC
thanks!