Bug 251606 - emulators/wine-devel: unbreak make makesum with STAGING for release candidates
Summary: emulators/wine-devel: unbreak make makesum with STAGING for release candidates
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-05 14:21 UTC by VVD
Modified: 2020-12-07 10:06 UTC (History)
0 users

See Also:
gerald: maintainer-feedback+


Attachments
unbreak make makesum with STAGING for release candidates (941 bytes, patch)
2020-12-05 14:21 UTC, VVD
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2020-12-05 14:21:26 UTC
Created attachment 220280 [details]
unbreak make makesum with STAGING for release candidates

But it still fail with error:
server/fd.c: In function 'open_fd':
server/fd.c:1986:18: error: 'O_SYMLINK' undeclared (first use in this function)
 1986 |         flags |= O_SYMLINK;
      |                  ^~~~~~~~~
server/fd.c:1986:18: note: each undeclared identifier is reported only once for each function it appears in
gmake[2]: *** [Makefile:159599: server/fd.o] Error 1

server/fd.c:
#if !defined(O_SYMLINK) && defined(O_PATH)
# define O_SYMLINK (O_NOFOLLOW | O_PATH)
#endif
Can't find definition of the O_PATH.
Comment 1 Gerald Pfeifer freebsd_committer 2020-12-05 16:40:01 UTC
Thanks for the patch.


For any issues with Wine Staging, please report those upstream; that's
really the best way.

Note the STAGING option is already labeled "experimental"; I'll be adding
"unsupported" to make that clear.


I devised a patch for the breakage you observed and reported the issue and
that patch upstream: https://bugs.winehq.org/show_bug.cgi?id=50255 .

You can expect an update of the port in the coming days.
Comment 2 commit-hook freebsd_committer 2020-12-07 10:03:31 UTC
A commit references this bug:

Author: gerald
Date: Mon Dec  7 10:03:03 UTC 2020
New revision: 557223
URL: https://svnweb.freebsd.org/changeset/ports/557223

Log:
  Adjust the download of the Staging patchset to the Wine 6.0 RC1 release
  and hence re-enable it. [1]

  Temporarily include a patch of mine to address a build breakage with
  that patchset, files/extrapatch-staging-server-fd.c.

  Update the description for the STAGING option and explicitly label it
  as unsupported.

  PR:		251606 [1]

Changes:
  head/emulators/wine-devel/Makefile
  head/emulators/wine-devel/distinfo
  head/emulators/wine-devel/files/extrapatch-staging-server-fd.c
  head/emulators/wine-devel/pkg-plist
Comment 3 Gerald Pfeifer freebsd_committer 2020-12-07 10:06:48 UTC
I have also reached out to the Wine Staging maintainers asking to follow
the same convention as Wine itself as they label their downloads (which
would have avoided the need to adjust DISTVERSION).