Bug 251620 - devel/msp430-debug-stack: Update to 3.15.1.1
Summary: devel/msp430-debug-stack: Update to 3.15.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-05 21:16 UTC by Kevin Zheng
Modified: 2022-04-14 10:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (lev)


Attachments
Patch (2.53 KB, patch)
2020-12-05 21:16 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2020-12-05 21:16:42 UTC
Update to 3.15.1.1. While here, add a patch that affects me:

I have a MSP430F5529 Launchpad connected via USB. Besides the issue where the devd config creates a broken symlink (PR 251616), I can't connect to my launchpad using mspdebug and tilib:

$ mspdebug tilib
MSPDebug version 0.25 - debugging tool for MSP430 MCUs
Copyright (C) 2009-2017 Daniel Beer <dlbeer@gmail.com>
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Chip info database from MSP430.dll v3.15.0.1 Copyright (C) 2013 TI, Inc.

Using new (SLAC460L+) API
MSP430_GetNumberOfUsbIfs
MSP430_GetNameOfUsbIf
Found FET: mspfet0013
MSP430_Initialize: mspfet0013
tilib: MSP430_Initialize: Interface Communication error (error = 35)
tilib: device initialization failed

With this attached patch that adds an additional delay to resetCommunication():

$ mspdebug tilib
MSPDebug version 0.25 - debugging tool for MSP430 MCUs
Copyright (C) 2009-2017 Daniel Beer <dlbeer@gmail.com>
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Chip info database from MSP430.dll v3.15.0.1 Copyright (C) 2013 TI, Inc.

Using new (SLAC460L+) API
MSP430_GetNumberOfUsbIfs
MSP430_GetNameOfUsbIf
Found FET: mspfet0013
MSP430_Initialize: mspfet0013
Firmware version is 31501001
MSP430_VCC: 3000 mV
MSP430_OpenDevice
MSP430_GetFoundDevice
Device: MSP430F5529 (id = 0x002f)

I'm not really sure why this additional delay is needed, but since tilib seems to be littered with these, I'm not sure it would hurt.
Comment 1 Kevin Zheng 2020-12-05 21:16:57 UTC
Created attachment 220294 [details]
Patch
Comment 2 Kevin Zheng 2021-09-08 19:00:18 UTC
Hi there, this patch has been waiting for maintainer-feedback since December 2020. Lev, could you approve the patch or suggest changes?
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2021-09-09 17:05:38 UTC
(In reply to Kevin Zheng from comment #2)
Oh, sorry. I'll look at this next week, I promise.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-14 10:48:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5278408663d464447ff40d3ec13b582306a982f8

commit 5278408663d464447ff40d3ec13b582306a982f8
Author:     Lev A. Serebryakov <lev@FreeBSD.org>
AuthorDate: 2022-04-14 10:47:15 +0000
Commit:     Lev A. Serebryakov <lev@FreeBSD.org>
CommitDate: 2022-04-14 10:48:09 +0000

    devel/msp430-debug-stack: Update to latest version 3.15.1.1

    PR:     251620

 devel/msp430-debug-stack/Makefile                        | 16 ++++++++--------
 devel/msp430-debug-stack/distinfo                        | 14 +++++++-------
 .../patch-DLL430__v3_src_TI_DLL430_FetControl.cpp (new)  | 11 +++++++++++
 devel/msp430-debug-stack/pkg-plist                       |  4 ++--
 4 files changed, 28 insertions(+), 17 deletions(-)
Comment 5 Lev A. Serebryakov freebsd_committer freebsd_triage 2022-04-14 10:50:02 UTC
Committed, at last.

NB: TI download site is very unstable and often gives timeouts. You need to try hard to download all distfiles :-(