Bug 251819 - devel/raylib: Missing header files (raymath.h, etc)
Summary: devel/raylib: Missing header files (raymath.h, etc)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Juraj Lutter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-13 16:54 UTC by Mattias Wikstrom
Modified: 2020-12-28 11:05 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+

Attachments
raylib.patch (822 bytes, patch)
2020-12-24 08:04 UTC, Martin Filla 		no flags Details | Diff
raylib.patch (830 bytes, patch)
2020-12-24 08:21 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
raylib.patch (728 bytes, patch)
2020-12-24 14:14 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
raylib.patch (944 bytes, patch)
2020-12-25 17:37 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
raylib.patch (1.07 KB, patch)
2020-12-25 18:06 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
raylib.patch (944 bytes, application/octet-stream)
2020-12-26 17:03 UTC, Juraj Lutter 		no flags Details
raylib.patch (1.16 KB, patch)
2020-12-26 19:44 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mattias Wikstrom 2020-12-13 16:54:41 UTC 
Hi, I noticed that this port does not install some of the crucial header files, this is also confirmed by the plist. The missing headers are from what I can gather:

raymath.h
rlgl.h
physac.h

Thanks for all your hard work!
Comment 1 Martin Filla 2020-12-24 08:04:06 UTC 
Created attachment 220883 [details]
raylib.patch

Hi,
this fix for missing includes
Comment 2 Martin Filla 2020-12-24 08:07:29 UTC 
(In reply to Mattias Wikstrom from comment #0)
Hi, 
thank you for report bug. Here is fix for missing raylib header.
F.
Comment 3 Martin Filla 2020-12-24 08:21:31 UTC 
Created attachment 220885 [details]
raylib.patch
Comment 4 Martin Filla 2020-12-24 14:14:38 UTC 
Created attachment 220891 [details]
raylib.patch

In raylib library are included rlgl.h, raudio.h. 
The patch added physac.h and raymath.h
Comment 5 Juraj Lutter freebsd_committer freebsd_triage 2020-12-25 17:13:23 UTC 
Two points:

- Please submit a patch with context
- Do not silence commands (${CP}, ${MV], ...) in Makefiles
Comment 6 Martin Filla 2020-12-25 17:37:29 UTC 
Created attachment 220913 [details]
raylib.patch

Remove silence command with @
Comment 7 Martin Filla 2020-12-25 18:06:15 UTC 
Created attachment 220914 [details]
raylib.patch

Bumped port version
Comment 8 Martin Filla 2020-12-26 08:42:56 UTC 
(In reply to Juraj Lutter from comment #5)
===========================================================================
=>> Checking for filesystem violations... done
=======================<phase: run-depends    >============================
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/ice.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/sm.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/x11.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xcursor.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xext.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xi.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xinerama.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xrandr.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xxf86vm.pc - found
===========================================================================
=>> Recording filesystem state for prestage... done
=======================<phase: stage          >============================
===>  Staging for raylib-3.0.0_2
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/ice.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/sm.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/x11.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xcursor.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xext.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xi.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xinerama.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xrandr.pc - found
===>   raylib-3.0.0_2 depends on file: /usr/local/libdata/pkgconfig/xxf86vm.pc - found
cp -f	/wrkdirs/usr/ports/devel/raylib/work/raylib-3.0.0/src/raylib.h  /wrkdirs/usr/ports/devel/raylib/work/raylib-3.0.0/src/raymath.h  /wrkdirs/usr/ports/devel/raylib/work/raylib-3.0.0/src/physac.h   /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/include
===>   Generating temporary packing list
[0/1] cd /wrkdirs/usr/ports/devel/raylib/work/.build && /usr/local/bin/cmake -DCMAKE_INSTALL_DO_STRIP=1 -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/lib/libraylib.so.3.0.0
-- Installing: /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/lib/libraylib.so.301
-- Set runtime path of "/wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/lib/libraylib.so.3.0.0" to "/usr/local/lib"
-- Installing: /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/lib/libraylib.so
-- Installing: /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/include/raylib.h
-- Installing: /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/lib/pkgconfig/raylib.pc
-- Installing: /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/lib/cmake/raylib/raylib-config-version.cmake
-- Installing: /wrkdirs/usr/ports/devel/raylib/work/stage/usr/local/lib/cmake/raylib/raylib-config.cmake
====> Compressing man pages (compress-man)
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=>> Checking for staging violations... done
=======================<phase: package        >============================
===>  Building package for raylib-3.0.0_2
===========================================================================
=>> Recording filesystem state for preinst... done
=======================<phase: install        >============================
===>  Installing for raylib-3.0.0_2
===>  Checking if raylib is already installed
===>   Registering installation for raylib-3.0.0_2
[freebsd12x64-default] Installing raylib-3.0.0_2...
===========================================================================
=>> Checking shared library dependencies
 0x0000000000000001 NEEDED               Shared library: [libGL.so.1]
 0x0000000000000001 NEEDED               Shared library: [libGLU.so.1]
 0x0000000000000001 NEEDED               Shared library: [libc.so.7]
 0x0000000000000001 NEEDED               Shared library: [libglfw.so.3]
 0x0000000000000001 NEEDED               Shared library: [libm.so.5]
 0x0000000000000001 NEEDED               Shared library: [libthr.so.3]
=======================<phase: deinstall      >============================
===>  Deinstalling for raylib
===>   Deinstalling raylib-3.0.0_2
Updating database digests format: .......... done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	raylib: 3.0.0_2

Number of packages to be removed: 1

The operation will free 1 MiB.
[freebsd12x64-default] [1/1] Deinstalling raylib-3.0.0_2...
[freebsd12x64-default] [1/1] Deleting files for raylib-3.0.0_2: .......... done
===========================================================================
=>> Checking for extra files and directories
[03:05:58] Installing from package
[freebsd12x64-default] Installing raylib-3.0.0_2...
[freebsd12x64-default] Extracting raylib-3.0.0_2: .......... done
[03:05:58] Cleaning up
===>  Cleaning for raylib-3.0.0_2
[03:05:58] Deinstalling package
Updating database digests format: . done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	raylib: 3.0.0_2

Number of packages to be removed: 1

The operation will free 1 MiB.
[freebsd12x64-default] [1/1] Deinstalling raylib-3.0.0_2...
[freebsd12x64-default] [1/1] Deleting files for raylib-3.0.0_2: .......... done
build of devel/raylib | raylib-3.0.0_2 ended at Sat Dec 26 01:24:36 CET 2020
build time: 00:00:27
[03:05:58] Logs: /data/logs/bulk/freebsd12x64-default/2020-12-25_22h18m38s
[03:05:58] Cleaning up
freebsd12x64-default: removed
freebsd12x64-default-n: removed
[03:05:58] Unmounting file systems
Comment 9 Juraj Lutter freebsd_committer freebsd_triage 2020-12-26 17:03:49 UTC 
Created attachment 220953 [details]
raylib.patch
Comment 10 Juraj Lutter freebsd_committer freebsd_triage 2020-12-26 17:29:41 UTC 
Comment on attachment 220953 [details]
raylib.patch

Erroneuously attached file.
Comment 11 Juraj Lutter freebsd_committer freebsd_triage 2020-12-26 17:30:23 UTC 
review D27776
Comment 12 Martin Filla 2020-12-26 19:44:00 UTC 
Created attachment 220959 [details]
raylib.patch
Comment 13 commit-hook freebsd_committer freebsd_triage 2020-12-28 11:05:00 UTC 
A commit references this bug:

Author: otis
Date: Mon Dec 28 11:04:25 UTC 2020
New revision: 559460
URL: https://svnweb.freebsd.org/changeset/ports/559460

Log:
  devel/raylib: Install missing header files

  The header files:
    - raymath.h
    - rlgl.h
    - physac.h

  were missing from the installation and pkg-plist.

  Also, while here, cleanup some style nits and bump PORTREVISION.

  PR:		251819
  Submitted by:	Martin Filla <freebsd@sysctl.cz> (maintainer)
  Reported by:	Mattias Wikstrom <burke@yagrebu.net>
  Reviewed by:	osa (mentor)
  Approved by:	osa (mentor)
  Differential Revision:	https://reviews.freebsd.org/D27776

Changes:
  head/devel/raylib/Makefile