Bug 251892 - sysutils/javaservicewrapper: fix build on powerpc64
Summary: sysutils/javaservicewrapper: fix build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-16 15:30 UTC by Piotr Kubaj
Modified: 2020-12-16 18:03 UTC (History)
2 users (show)

See Also:
michael.osipov: maintainer-feedback+


Attachments
patch (808 bytes, patch)
2020-12-16 15:30 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (michael.osipov)
Details | Diff
log (50.02 KB, text/plain)
2020-12-16 17:03 UTC, Piotr Kubaj
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2020-12-16 15:30:08 UTC
Created attachment 220625 [details]
patch

This software builds just fine on powerpc64 if you simply copy the amd64 makefile.
Comment 1 Michael Osipov 2020-12-16 15:43:18 UTC
Will have a look.
Comment 2 Michael Osipov 2020-12-16 15:43:41 UTC
Out of curiousity, is that port-dependent or your software?
Comment 3 Piotr Kubaj freebsd_committer 2020-12-16 16:05:57 UTC
(In reply to Michael Osipov from comment #2)
The Makefile copy is performed in the port's Makefile. Since all the Makefiles for FreeBSD actually look the same, copying one from other architecture works.
Comment 4 Michael Osipov 2020-12-16 16:09:47 UTC
(In reply to Piotr Kubaj from comment #3)

So everything works for you? The tests from the Ant build file pass for you?
Comment 5 Piotr Kubaj freebsd_committer 2020-12-16 17:03:54 UTC
Created attachment 220629 [details]
log

Yes, the port seems to build fine, I attached a Poudriere log.
Comment 6 commit-hook freebsd_committer 2020-12-16 17:10:11 UTC
A commit references this bug:

Author: pkubaj
Date: Wed Dec 16 17:09:26 UTC 2020
New revision: 558229
URL: https://svnweb.freebsd.org/changeset/ports/558229

Log:
  sysutils/javaservicewrapper: fix build on powerpc64

  PR:		251892
  Approved by:	michael.osipov@siemens.com (maintainer)
  MFH:		2020Q4

Changes:
  head/sysutils/javaservicewrapper/Makefile
Comment 7 commit-hook freebsd_committer 2020-12-16 17:10:12 UTC
A commit references this bug:

Author: pkubaj
Date: Wed Dec 16 17:10:09 UTC 2020
New revision: 558230
URL: https://svnweb.freebsd.org/changeset/ports/558230

Log:
  MFH: r558229

  sysutils/javaservicewrapper: fix build on powerpc64

  PR:		251892
  Approved by:	michael.osipov@siemens.com (maintainer)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/sysutils/javaservicewrapper/Makefile
Comment 8 Michael Osipov 2020-12-16 17:24:42 UTC
Looks good to me. Have you consider reporting it here: https://sourceforge.net/p/wrapper/feature-requests/?

I have already created several tickets and all were handled in time.
Comment 9 Piotr Kubaj freebsd_committer 2020-12-16 18:03:40 UTC
Sorry, looks like I committed this fix prior to your approval.

A maintainer feedback from another PR came in (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251891) and I got them mixed.

Nevertheless, thanks, I will report this to upstream.