Created attachment 220804 [details] Patch (Revision 1) Passes poudriere.
Created attachment 220806 [details] Patch (Revision 2) New version 0.7.1
Hi! Thanks for the patch. The changelog (https://github.com/AsamK/signal-cli/blob/master/CHANGELOG.md) mentions that libzkgroup is a new runtime dependency. I guess we should investigate that before we upgrade the port.
I also tried to update signal-cli to 0.7.1. It builds fine in poudriere, but fails at runtime due to that missing library. Here is my work in progress in case it saves a little time: https://github.com/Jehops/freebsd-ports/commit/9f26cb2fa9b34ccde393d44d88f492fbc88f47fc If you do create a new port for zkgroup, it's better if you make someone other than me the maintainer. I add myself just for testing, but I don't know much about rust and I will be short on time in the next few months. Maybe it doesn't even need to be a separate port though. The authors say that it's only suitable for use with signal for now.
(In reply to Joseph Mingrone from comment #3) Amazing, thanks a lot. The library should have a separate port I think, the signal-cli port is already too complicated.
A commit references this bug: Author: 0mp Date: Wed Dec 23 02:29:59 UTC 2020 New revision: 558956 URL: https://svnweb.freebsd.org/changeset/ports/558956 Log: Add net-im/zkgroup zkgroup is a library for the Signal Private Group System. It is a new dependency for net-im/signal-cli. WWW: https://github.com/signalapp/zkgroup PR: 252041 Submitted by: jrm@ (earlier version) Changes: head/net-im/Makefile head/net-im/zkgroup/ head/net-im/zkgroup/Makefile head/net-im/zkgroup/distinfo head/net-im/zkgroup/files/ head/net-im/zkgroup/files/patch-cargo-crates_jni-0.16.0_build.rs head/net-im/zkgroup/pkg-descr
I am getting the following error now: WARNING: Support for new group V2 is disabled, because the required native library dependency is missing: libzkgroup Error loading state file: Could not initialize class org.signal.zkgroup.internal.Native Here's the current patch status: https://reviews.freebsd.org/D27734
(In reply to Mateusz Piotrowski from comment #6) Hi Mateusz, I was getting that error before, but with your new net-im/zkgroup port in the tree, signal-cli-0.7.1 is working fine for me. I built with the DBUS knob off, but when I turned on the knob on and tried to start the rc script, I got "unrecognized arguments: '--system'". Unrelated to any error, I did make a minor, local change to net-im/zkgroup by updating the USE_JAVA line to say USE_JAVA= 11+. This was just so that I wouldn't have to install two different versions of openjdk. Thanks, Joe
A commit references this bug: Author: 0mp Date: Wed Dec 23 11:39:39 UTC 2020 New revision: 558982 URL: https://svnweb.freebsd.org/changeset/ports/558982 Log: Update to 0.7.1 Changelog: https://github.com/AsamK/signal-cli/blob/v0.7.1/CHANGELOG.md PR: 252041 Submitted by: Neel Chauhan <neel@neelc.org> (earlier version) Reviewed by: jrm@ Differential Revision: https://reviews.freebsd.org/D27734 Changes: head/net-im/signal-cli/Makefile head/net-im/signal-cli/distinfo head/net-im/signal-cli/pkg-plist
Thanks everyone, the port seems to be working fine now. 0.7.1 has landed!
Looks good. Thanks to both of you.