Created attachment 220811 [details]
Hi all, I'm the port maintainer for graphics/p5-Image-ExifTool.
The perl Image::ExifTool module version history is described here:
As you can see, periodically, certain version of exiftool are designated as "production versions".
The graphics/p5-Image-ExifTool port tracks the current production version of exiftool, which at this moment is version 12.00.
For non-production versions, please use the graphics/p5-Image-ExifTool-devel port which is used to track off-cycle releases.
For this reason I do not approve the patch to 12.12 for graphics/p5-Image-ExifTool.
Thanks Tod, for the clarification.
@takefu: I think, you should close this PR and probably open a new one for graphics/p5-Image-ExifTool-devel, as mentioned by Tod?
Created attachment 220846 [details]
Moved to p5-Image-ExifTool-devel
Created attachment 220847 [details]
a bit unusual, but probably it works that way, 'reusing' the previous PR now for the devel version ;)
Two issues I noticed:
(1) The new patch on the port graphics/p5-Image-ExifTool-devel has a different maintainer: Daniel Lin <firstname.lastname@example.org>. You should ask for maintainer-approval from him by setting the corresponding flag of the patch in the attachment area to '?' ...
(2) With your patch, 'portlint -AC' complains about USES=, which has to appear earlier. This is because of two CONFLICTS lines, the first one is obsolete(?):
--- Makefile.orig 2020-12-23 16:30:09.561458000 +0100
+++ Makefile 2020-12-23 16:37:29.726380000 +0100
@@ -14,8 +14,6 @@
LICENSE= ART10 GPLv1+
Created attachment 220898 [details]
fix portlint -AC
A commit references this bug:
Date: Sat Jan 9 18:59:14 UTC 2021
New revision: 560886
graphics/p5-Image-ExifTool-devel: Update to 12.14
Update of the development version from 10.66 (Nov. 14, 2017)
to recent 12.14.
Submitted by: email@example.com
Approved by: arrowd (mentor), + maintainer timout (> 2 weeks)
Differential Revision: https://reviews.freebsd.org/D28063
Committed, thanks :)