Bug 252085 - new port: editors/codelite-devel: powerful open-source, cross platform code editor for the C/C++ programming languages (development version)
Summary: new port: editors/codelite-devel: powerful open-source, cross platform code e...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-23 18:05 UTC by Ivan Rozhuk
Modified: 2021-07-21 03:09 UTC (History)
4 users (show)

See Also:


Attachments
patch (22.48 KB, patch)
2020-12-23 18:05 UTC, Ivan Rozhuk
no flags Details | Diff
patch (22.39 KB, patch)
2021-02-15 12:23 UTC, Ivan Rozhuk
no flags Details | Diff
patch (25.96 KB, patch)
2021-07-21 03:09 UTC, Ivan Rozhuk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2020-12-23 18:05:23 UTC
Created attachment 220867 [details]
patch

CodeLite is a powerful open-source, cross platform code editor for the
C/C++ programming languages.

CodeLite uses a sophisticated, yet intuitive interface which allows
user to easy create and build complex projects.

WWW: https://codelite.org/
Comment 1 Daniel Engberg 2021-01-30 10:37:39 UTC
Hi,

Given the discussion in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252738 can you perhaps adapt this patch to the main port instead of creating -devel?

Best regards,
Daniel
Comment 2 Rainer Hurling freebsd_committer 2021-01-30 11:27:41 UTC
(In reply to daniel.engberg.lists from comment #1)
Hi Ivan,

Is it also possible to you to update your patch to v15.0.0 [1] (release version)? That would be really great :)


[1] https://github.com/eranif/codelite/commit/53713d80b98cca07fef5e0f697497613f18adcff
Comment 3 Ivan Rozhuk 2021-02-15 12:23:36 UTC
Created attachment 222464 [details]
patch
Comment 4 Daniel Engberg 2021-02-15 21:58:45 UTC
Hi Ivan,

Can we transfer this to the main port instead? It's soon going to be broken due to bumping pango.

A few things that can be improved by looking at your Makefile

L4 and L26: Please follow Porter's Handbook 
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-ex5

L12 Seems to be GPLv2 ?
Define LICENSE_FILE
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#licenses-license_file-ex1

L17 Remove?

L27 is already defined by the framework
https://svnweb.freebsd.org/ports/head/Mk/Uses/cmake.mk?revision=488341&view=markup#l68

L34 is this really needed and if it is, please use a proper DEBUG menu option
https://github.com/eranif/codelite/blob/master/CMakeLists.txt#L429

L105, are you really sure about that?

There is quite a bit of REINPLACE_CMD going on, this is in general discouraged perhaps usage can be reduced and replaced with patches?

Some things are out of order, have a look at portlint and/or portclippy

Does it pass poudriere?

Great work!
Daniel
Comment 5 mburetorp 2021-02-20 15:51:43 UTC
Good work getting v15 to FreeBSD ports. I look forward to this p
Comment 6 mburetorp 2021-02-20 15:55:14 UTC
Sorry for that incomplete message. I just wanted to say good work! Now that v15 is released the main port should probably be updated.
Comment 7 Ivan Rozhuk 2021-07-21 03:09:17 UTC
Created attachment 226576 [details]
patch