Bug 252098 - devel/libgit2: is too old for some USES=cargo ports
Summary: devel/libgit2: is too old for some USES=cargo ports
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Fechner
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2020-12-24 06:07 UTC by Jan Beich
Modified: 2021-02-14 19:08 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mfechner)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2020-12-24 06:07:46 UTC
A number of ports Rust-based ports expect libgit2 1.1.0 due to LIBGIT2_SYS_USE_PKG_CONFIG=1. For example, I had to add an extra patch in ports r559049.

Can you update to https://github.com/libgit2/libgit2/releases/tag/v1.1.0 ?

$ rg -lt make libgit2-sys.\*1.1.0
devel/cargo-c/Makefile
devel/gitui/Makefile
security/cargo-audit/Makefile
shells/starship/Makefile
sysutils/onefetch/Makefile
textproc/bat/Makefile
Comment 1 Matthias Fechner freebsd_committer 2020-12-24 07:38:17 UTC
Even after the upgrade of gitlab to 13.7 libgit2 1.1.0 does not work with gitlab.
Here the branch I tested:
https://gitlab.fechner.net/mfechner/Gitlab/-/tree/libgit110

The failing log is here:
https://pkg.fechner.net/data/122amd64-gitlab/2020-12-24_08h23m17s/logs/errors/gitaly-13.7.0.log

The full build here:
https://pkg.fechner.net/build.html?mastername=122amd64-gitlab&build=2020-12-24_08h23m17s

Maybe we can ask upstream to upgrade gitaly to use a newer version of `github.com/libgit2/git2go/v30` which works with libgit2 1.1.0 version.
Comment 2 daniel.engberg.lists 2021-02-14 19:08:50 UTC
There's an issue open upstream about this:
https://gitlab.com/gitlab-org/gitaly/-/issues/3330