Bug 252258 - www/spreadlogd: fix the build on -CURRENT
Summary: www/spreadlogd: fix the build on -CURRENT
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 252245
  Show dependency treegraph
 
Reported: 2020-12-29 05:59 UTC by Kyle Evans
Modified: 2021-01-10 17:48 UTC (History)
2 users (show)

See Also:
portmaster: maintainer-feedback+


Attachments
git(1) diff against the ports tree (713 bytes, patch)
2020-12-29 05:59 UTC, Kyle Evans
no flags Details | Diff
svn diff for www/spreadlogd version 2 (517 bytes, patch)
2020-12-30 21:55 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2020-12-29 05:59:03 UTC
Created attachment 221077 [details]
git(1) diff against the ports tree

libgnuregex has been removed in -CURRENT. Switch to using the newer version that's provided in ports as of ports r559542.
Comment 1 Chris Hutchinson 2020-12-29 07:19:11 UTC
Comment on attachment 221077 [details]
git(1) diff against the ports tree

Thanks, Kyle!
Comment 2 Fernando Apesteguía freebsd_committer 2020-12-30 18:31:08 UTC
^Triage: Reporter is committer, assign accordingly.

Q/A:  Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '.

 /tmp/252258/www/spreadlogd/files/patch-config.h: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/252258/www/spreadlogd/files/patch-makefile: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/252258/www/spreadlogd/files/patch-spreadlogd.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

Thanks!
Comment 3 Chris Hutchinson 2020-12-30 21:31:25 UTC
(In reply to Fernando Apesteguía from comment #2)
All of the patches created in files were created eith
diff(1) and work at least as well intended as anything
that uses makepatch, which also uses diff(1).

I'll address the COMMENT "nit" shortly. :-)
Comment 4 Chris Hutchinson 2020-12-30 21:55:29 UTC
Created attachment 221114 [details]
svn diff for www/spreadlogd version 2

Changes addressing comment #2

This should do it. :-)

--Chris
Comment 5 Kyle Evans freebsd_committer 2021-01-10 17:48:22 UTC
(In reply to Chris Hutchinson from comment #4)

Sorry for the delay on this -- AFAICT the package version test format isn't valid for LIB_DEPENDS:

    ===>  Applying FreeBSD patches for spreadlogd-1.4.2 from 
    /usr/local/poudriere/ports/default/www/spreadlogd/files
    Error: pattern libgnuregex>5 in LIB_DEPENDS is not valid

I think I'm going to look at patching portlint to squelch the warning that change was addressing specifically for this lib in the form of a general "lib competing with base" list kind of thing. We do similar shenanigans with, e.g., openssl to make sure we don't use the base version if the ports version has been selected.