Bug 252335 - print/cups-filters: add possibility to use ImageMagick 7 if BRAILLE build option is on
Summary: print/cups-filters: add possibility to use ImageMagick 7 if BRAILLE build opt...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-01 18:25 UTC by Vladimir Druzenko
Modified: 2021-02-12 09:15 UTC (History)
5 users (show)

See Also:
tijl: maintainer-feedback+

Attachments
Add possibility to use ImageMagick 7 if BRAILLE build option is on (2.30 KB, patch)
2021-01-01 18:25 UTC, Vladimir Druzenko 		vvd: maintainer-approval?
Details | Diff
Add IMAGEMAGICK_DEFAULT version (681 bytes, patch)
2021-01-20 12:30 UTC, Vladimir Druzenko 		vvd: maintainer-approval? (tijl)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2021-01-01 18:25:35 UTC 
Created attachment 221170 [details]
Add possibility to use ImageMagick 7 if BRAILLE build option is on

Tested on 12.2 amd64: check-plist, build, run.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2021-01-12 12:52:09 UTC 
Something wrong with patch?
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2021-01-19 09:33:19 UTC 
Maintainer timeout?
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2021-01-19 10:41:30 UTC 
maintainer timeout
Comment 4 Tijl Coosemans freebsd_committer freebsd_triage 2021-01-20 10:29:06 UTC 
A better solution I think would be to add IMAGEMAGICK_DEFAULT to Mk/bsd.default-versions.mk so the dependency can be declared using convert:graphics/ImageMagick${IMAGEMAGICK_DEFAULT}.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2021-01-20 12:21:25 UTC 
(In reply to Tijl Coosemans from comment #4)
This is a good idea, but who can implement it?
Is it require USES=imagemagick support too?
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2021-01-20 12:30:00 UTC 
Created attachment 221767 [details]
Add IMAGEMAGICK_DEFAULT version

Did you said about this?
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2021-02-10 10:18:49 UTC 
Tijl Coosemans, check plz patch: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=221767&action=diff
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-02-11 17:17:19 UTC 
A commit references this bug:

Author: tijl
Date: Thu Feb 11 17:16:29 UTC 2021
New revision: 564968
URL: https://svnweb.freebsd.org/changeset/ports/564968

Log:
  Introduce ImageMagick default version and use it in print/cups-filters.

  The different versions of ImageMagick in the ports tree all conflict with
  each other and some ports can depend on either of them so it's a perfect
  candidate for the default-versions framework.

  PR:		252335
  Submitted by:	VVD <vvd@unislabs.com>

Changes:
  head/Mk/bsd.default-versions.mk
  head/print/cups-filters/Makefile
Comment 9 Tijl Coosemans freebsd_committer freebsd_triage 2021-02-11 17:19:43 UTC 
Apologies for the delays.
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2021-02-11 18:53:00 UTC 
Ports (I'm using) need to be updated for respect IMAGEMAGICK_DEFAULT:
graphics/pecl-imagick + graphics/pecl-imagick-im7
graphics/rubygem-mini_magick
graphics/zbar
multimedia/libopenshot
multimedia/lives - my port
multimedia/libxine - I'll create patch
Comment 11 Vladimir Druzenko freebsd_committer freebsd_triage 2021-02-11 21:12:43 UTC 
multimedia/lives: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253442
multimedia/libxine: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253443
Comment 12 Tatsuki Makino 2021-02-11 21:29:26 UTC 
(In reply to Tijl Coosemans from comment #4)
(In reply to VVD from comment #10)

multimedia/libopenshot needs LIB_DEPENDS.
In that case, should I write the following?

LIB_DEPENDS= libMagick++-${IMAGEMAGICK_DEFAULT}.so:graphics/ImageMagick${IMAGEMAGICK_DEFAULT}

Doesn't it have to be LIB_DEPENDS as long as a properly linked binary is created?
Such that the result of the following command will be correct.

pkg info -B py37-libopenshot
Comment 14 Tijl Coosemans freebsd_committer freebsd_triage 2021-02-12 09:15:00 UTC 
(In reply to Tatsuki Makino from comment #12)
Yes, that LIB_DEPENDS line looks correct.

LIB_DEPENDS is converted to BUILD_DEPENDS+RUN_DEPENDS rather early.  It does not affect package builds.  The libraries linked into binaries are determined by the upstream build system.  The output of pkg info is derived from scanning the binaries.