Bug 252357 - textproc/aspell: Doesn't need DOCS option
Summary: textproc/aspell: Doesn't need DOCS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Office Team
Depends on:
Reported: 2021-01-02 19:14 UTC by Naram Qashat
Modified: 2024-01-31 04:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (office)


Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2021-01-02 19:14:17 UTC
The textproc/aspell port has the DOCS option explicitly stated in its OPTIONS_DEFINE. However, it does not utilize the option at all. The file contents of the packages with or without the option enabled are identical. The option should ideally be removed.
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-01-31 04:40:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=09b65d60120f8d75a7d799e4f8ea02468334d3e7

commit 09b65d60120f8d75a7d799e4f8ea02468334d3e7
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2024-01-31 04:38:02 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2024-01-31 04:38:02 +0000

    textproc/aspell: garbage-collect DOCS option (now useless)

    As of r332672, manpages are always installed and condition
    .if ${PORT_OPTIONS:MDOCS} had been removed; since the port
    does not install any other documentation, drop it from the
    option list as well.  While here, sort INFO alphabetically
    and GC the linking gimmick added for version back
    in 2003 (r94146, now commit ed1d8c2ac3336): these days, it
    builds and links fine regardless of the optimization level.

    PR:     252357
    Fixes:  f027257d68fb6

 textproc/aspell/Makefile | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2024-01-31 04:42:21 UTC
Option had been removed, thanks for noticing!