Bug 252383 - [NEW PORT] textproc/md4c Markdown Parser in C
Summary: [NEW PORT] textproc/md4c Markdown Parser in C
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-03 14:05 UTC by Henrik Rosenke
Modified: 2021-01-11 23:40 UTC (History)
2 users (show)

See Also:


Attachments
diff for new port textproc/md4c (3.18 KB, patch)
2021-01-03 14:05 UTC, Henrik Rosenke
no flags Details | Diff
new-diff-md4c (3.55 KB, patch)
2021-01-11 22:00 UTC, Henrik Rosenke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Rosenke 2021-01-03 14:05:30 UTC
Created attachment 221242 [details]
diff for new port textproc/md4c

Markdown Parser in C. 
Needed for Purism L5 Simple Diary app. https://lists.freebsd.org/pipermail/freebsd-ports/2021-January/119979.html

Contains md4c and md2html.

This is my first svn diff and maintaining for a port, hopefully it contains all things needed.
Comment 1 Matthias Apitz 2021-01-06 10:08:39 UTC
I applied the patch which gives some messages:

root@c720-r368166:/usr/ports # patch -p0 < ~guru/md4c.diff
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: textproc/md4c/Makefile
|===================================================================
|--- textproc/md4c/Makefile	(nicht existent)
|+++ textproc/md4c/Makefile	(Arbeitskopie)
--------------------------
(Creating file textproc/md4c/Makefile...)
Patching file textproc/md4c/Makefile using Plan A...
Empty context always matches.
Hunk #1 succeeded at 1.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|
|Property changes on: textproc/md4c/Makefile
|___________________________________________________________________
|Added: svn:eol-style
|## -0,0 +1 ##
|+native
|\ No newline at end of property
|Added: svn:keywords
|## -0,0 +1 ##
|+FreeBSD=%H
|\ No newline at end of property
|Added: svn:mime-type
|## -0,0 +1 ##
|+text/plain
|\ No newline at end of property
|Index: textproc/md4c/distinfo
|===================================================================
|--- textproc/md4c/distinfo	(nicht existent)
|+++ textproc/md4c/distinfo	(Arbeitskopie)
--------------------------
(Creating file textproc/md4c/distinfo...)
Patching file textproc/md4c/distinfo using Plan A...
Empty context always matches.
Hunk #1 succeeded at 1.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|
|Property changes on: textproc/md4c/distinfo
|___________________________________________________________________
|Added: fbsd:nokeywords
|## -0,0 +1 ##
|+yes
|\ No newline at end of property
|Added: svn:eol-style
|## -0,0 +1 ##
|+native
|\ No newline at end of property
|Added: svn:mime-type
|## -0,0 +1 ##
|+text/plain
|\ No newline at end of property
|Index: textproc/md4c/pkg-descr
|===================================================================
|--- textproc/md4c/pkg-descr	(nicht existent)
|+++ textproc/md4c/pkg-descr	(Arbeitskopie)
--------------------------
(Creating file textproc/md4c/pkg-descr...)
Patching file textproc/md4c/pkg-descr using Plan A...
Empty context always matches.
Hunk #1 succeeded at 1.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|
|Property changes on: textproc/md4c/pkg-descr
|___________________________________________________________________
|Added: fbsd:nokeywords
|## -0,0 +1 ##
|+yes
|\ No newline at end of property
|Added: svn:eol-style
|## -0,0 +1 ##
|+native
|\ No newline at end of property
|Added: svn:mime-type
|## -0,0 +1 ##
|+text/plain
|\ No newline at end of property
|Index: textproc/md4c/pkg-plist
|===================================================================
|--- textproc/md4c/pkg-plist	(nicht existent)
|+++ textproc/md4c/pkg-plist	(Arbeitskopie)
--------------------------
(Creating file textproc/md4c/pkg-plist...)
Patching file textproc/md4c/pkg-plist using Plan A...
Empty context always matches.
Hunk #1 succeeded at 1.
Hmm...  Ignoring the trailing garbage.
done

but 'make' and 'make install' do fine:

root@c720-r368166:/usr/ports/textproc/md4c # make install
===>  Installing for md4c-0.4.7
===>  Checking if md4c is already installed
===>   Registering installation for md4c-0.4.7
Installing md4c-0.4.7...
Comment 2 Henrik Rosenke 2021-01-06 10:22:34 UTC
Thank you for trying this. Does this mean something in the diff is missing or needs to be edited? 

Greetings, Henrik Rosenke
Comment 3 Matthias Apitz 2021-01-06 10:41:36 UTC
I think for each file in the diff the part about the SVN properties shouldn't be there. How do you created the file?
Comment 4 Henrik Rosenke 2021-01-06 11:01:45 UTC
(In reply to Matthias Apitz from comment #3)

maybe this was caused by creating this on my ubuntu workstation, i have built the port on our poudriere Server but the Server has an older portstree. So i checked it out on my workstation, and created the svn diff there. i can filter this via svn diff | filterdiff --clean but this surpresses this section:

Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property

But it seems other ports got this property line in their diff as well?

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252460 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252412 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243845
Comment 5 daniel.engberg.lists 2021-01-09 20:01:32 UTC
L15 should say DISTVERSION instead of PORTVERSION for consistency.

L3 in pkg-descr should be separated from the rest of the text and the text should be a bit more verbose.

Looks good to me otherwise!

Best regards,
Daniel
Comment 6 Henrik Rosenke 2021-01-11 22:00:15 UTC
Created attachment 221478 [details]
new-diff-md4c

Thanks for the tips Daniel,

i added these Changes to the new diff.