Bug 252424 - Mk/Uses/python.mk: Remove broken shared macros (chase removal of graphics/py-pillow6)
Summary: Mk/Uses/python.mk: Remove broken shared macros (chase removal of graphics/py-...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-python (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-01-04 23:56 UTC by Yasuhiro Kimura
Modified: 2021-06-21 03:43 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
Patch file (52.69 KB, patch)
2021-01-04 23:56 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (43.29 KB, patch)
2021-02-03 16:37 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (43.27 KB, patch)
2021-03-28 17:40 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (47.80 KB, patch)
2021-04-27 03:16 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (47.80 KB, patch)
2021-05-24 16:52 UTC, Yasuhiro Kimura
no flags Details | Diff
Updated patch file (47.96 KB, patch)
2021-06-20 17:19 UTC, Yasuhiro Kimura
koobs: maintainer-approval? (python)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura 2021-01-04 23:56:15 UTC
Created attachment 221276 [details]
Patch file

Chase removal of graphics/py-pillow6.
    
After it's removed, ports that requires py-pillow don't work with python 2.7. So make following changes.
    
* Adjust python range of some ports so they don't use python 2.7.
* Remove PY_PILLOW from Mk/Uses/python.mk.
* Replace '${PY_PILLOW}' in dependency of each port with direct one to graphics/py-pillow.
    
This also fixes error of `make index` when default version of python is 3.8 or later.
Comment 1 Yasuhiro Kimura 2021-02-03 16:37:38 UTC
Created attachment 222125 [details]
Updated patch file

Update patch to make it fit to the latest ports tree.
Comment 2 Yasuhiro Kimura 2021-03-28 17:40:32 UTC
Created attachment 223668 [details]
Updated patch file

Chase update of ports tree.
Comment 3 Yasuhiro Kimura 2021-04-27 03:16:40 UTC
Created attachment 224461 [details]
Updated patch file

Chase update of ports tree.
Comment 4 Yasuhiro Kimura 2021-04-27 09:46:54 UTC
@koobs

Would you please commit my latest patch?

Best Regards.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-24 03:15:16 UTC
Apologies for the delay Yasuhiro. Is this patch still ready to go and up to date?
Comment 6 Yasuhiro Kimura 2021-05-24 16:52:00 UTC
Created attachment 225228 [details]
Updated patch file

Chase update of ports tree.
Comment 7 Yasuhiro Kimura 2021-05-24 16:52:44 UTC
(In reply to Kubilay Kocak from comment #5)

I updated patch. So please use latest one.
Comment 8 Yasuhiro Kimura 2021-06-20 17:19:39 UTC
Created attachment 225952 [details]
Updated patch file

Chase update of ports tree.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2021-06-21 01:47:08 UTC
(In reply to Yasuhiro Kimura from comment #8)

Much appreciated Yasuhirosan
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2021-06-21 01:49:22 UTC
(In reply to Yasuhiro Kimura from comment #8)

Apologies, I forgot to ask... do all of the <version-specs> for each port match those that are defined in the upstream sources?

In particular:

 - Any "<Y" specifiers must be included
 - All > or >= specifiers must be exact version number matches

Thank you!
Comment 11 Yasuhiro Kimura 2021-06-21 03:31:10 UTC
(In reply to Kubilay Kocak from comment #10)

My patch simply replaces "${PY_PILLOW}" in Makefile of each port with "${PYTHON_PKGNAMEPREFIX}pillow>=7.0.0:graphics/py-pillow@${PY_FLAVOR}".
So if these ports currently work fine, they also should do after my patch is applied.
Comment 12 Kubilay Kocak freebsd_committer freebsd_triage 2021-06-21 03:43:44 UTC
(In reply to Yasuhiro Kimura from comment #11)

We'll want to check that those lines match the source specifiers. 

See Also: bug 243665 comment 1