Bug 252470 - databases/luasql-mysql: update to 2.6.0
Summary: databases/luasql-mysql: update to 2.6.0
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-06 13:21 UTC by Marco Beishuizen
Modified: 2021-01-07 17:44 UTC (History)
1 user (show)

See Also:


Attachments
databases/luasql-mysql: update luasql to 2.6.0 (964 bytes, patch)
2021-01-06 13:21 UTC, Marco Beishuizen
mbeis: maintainer-approval+
Details | Diff
databases/luasql-mysql: update to 2.6.0 (1.25 KB, patch)
2021-01-06 19:37 UTC, Marco Beishuizen
mbeis: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Beishuizen 2021-01-06 13:21:47 UTC
Created attachment 221324 [details]
databases/luasql-mysql: update luasql to 2.6.0

Update the Luasql ports to 2.6.0
Comment 1 Fernando Apesteguía freebsd_committer 2021-01-06 18:17:45 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A:  Makefile: [15]: USE_* seen before USES.  According to the porters-handbook, USES must appear first.
 Makefile: PKGNAMEPREFIX appears out-of-order.
 Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY.
 Makefile: "COMMENT" has to appear earlier.
 Makefile: "IGNORE" has to appear earlier.
 Makefile: "USES" has to appear earlier.

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html

Some of the errors will go away one the first line is put in place.

Thanks!
Comment 2 Marco Beishuizen 2021-01-06 19:37:46 UTC
Created attachment 221333 [details]
databases/luasql-mysql: update to 2.6.0

Portlint almost happy... Couldn't get rid of the comment warning.
Comment 3 Fernando Apesteguía freebsd_committer 2021-01-07 13:22:45 UTC
(In reply to Marco Beishuizen from comment #2)
Don't worry. portlint refers to COMMENT and IGNORE which are conditionals but it lacks the context to know that.

I think the patch is good.

Thanks for the changes!