Bug 252502 - games/libretro-beetle_bsnes: update to 0.20210101
Summary: games/libretro-beetle_bsnes: update to 0.20210101
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-01-08 06:23 UTC by Ivan Rozhuk
Modified: 2021-02-12 18:02 UTC (History)
3 users (show)

See Also:
dmenelkir: maintainer-feedback+
fernape: merge-quarterly?


Attachments
patch (1.79 KB, patch)
2021-01-08 06:31 UTC, Ivan Rozhuk
rozhuk.im: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2021-01-08 06:23:44 UTC
Upstream already have fix: https://github.com/libretro/beetle-bsnes-libretro/commit/b65ded5bde278c18af538c687db9b72c995b220a

In file included from mednafen/snes/src/chip/srtc/srtc.cpp:1:
In file included from ./mednafen/snes/src/lib/../base.hpp:46:
In file included from ./mednafen/snes/src/lib/../interface.hpp:19:
In file included from ./mednafen/snes/src/lib/../cpu/core/core.hpp:3:
./mednafen/snes/src/lib/../cpu/core/registers.hpp:15:54: error: no matching member function for call to 'operator='
  inline unsigned operator|=(unsigned data) { return operator=(operator unsigned() | data); }
                                                     ^~~~~~~~~
./mednafen/snes/src/lib/../cpu/core/registers.hpp:1:8: note: candidate function (the implicit move assignment operator) not viable: no known conversion from 'unsigned int' to 'SNES::CPUcore::flag_t' for 1st argument
struct flag_t {
       ^
./mednafen/snes/src/lib/../cpu/core/registers.hpp:1:8: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'unsigned int' to 'const SNES::CPUcore::flag_t' for 1st argument
struct flag_t {
       ^
./mednafen/snes/src/lib/../cpu/core/registers.hpp:16:54: error: no matching member function for call to 'operator='
  inline unsigned operator^=(unsigned data) { return operator=(operator unsigned() ^ data); }
                                                     ^~~~~~~~~
./mednafen/snes/src/lib/../cpu/core/registers.hpp:1:8: note: candidate function (the implicit move assignment operator) not viable: no known conversion from 'unsigned int' to 'SNES::CPUcore::flag_t' for 1st argument
struct flag_t {
       ^
./mednafen/snes/src/lib/../cpu/core/registers.hpp:1:8: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'unsigned int' to 'const SNES::CPUcore::flag_t' for 1st argument
struct flag_t {
       ^
./mednafen/snes/src/lib/../cpu/core/registers.hpp:17:54: error: no matching member function for call to 'operator='
  inline unsigned operator&=(unsigned data) { return operator=(operator unsigned() & data); }
                                                     ^~~~~~~~~
./mednafen/snes/src/lib/../cpu/core/registers.hpp:1:8: note: candidate function (the implicit move assignment operator) not viable: no known conversion from 'unsigned int' to 'SNES::CPUcore::flag_t' for 1st argument
struct flag_t {
       ^
./mednafen/snes/src/lib/../cpu/core/registers.hpp:1:8: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'unsigned int' to 'const SNES::CPUcore::flag_t' for 1st argument
struct flag_t {
       ^
3 errors generated.
Comment 1 Ivan Rozhuk 2021-01-08 06:31:14 UTC
Created attachment 221377 [details]
patch
Comment 2 Daniel Menelkir 2021-01-08 21:26:29 UTC
I can't test it right now, but if it works for you, feel free to merge.
Comment 3 Ivan Rozhuk 2021-01-10 16:01:20 UTC
Build - OK.
Do not test result is work, but see no reason why it should not.

Have no idea how to merge here :)
Comment 4 Daniel Menelkir 2021-01-11 10:04:13 UTC
(In reply to rozhuk.im from comment #3)
I mean "commit the changes", sorry.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-02-12 18:02:50 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Feb 12 18:01:59 UTC 2021
New revision: 565041
URL: https://svnweb.freebsd.org/changeset/ports/565041

Log:
  - Update to 0.20210101

  PR:		252502
  Submitted by:	rozhuk.im@gmail.com
  Approved by:	menelkir@itroll.org (maintainer)

Changes:
  head/games/libretro-beetle_bsnes/Makefile
  head/games/libretro-beetle_bsnes/distinfo