Bug 252537 - emulators/wine-proton: remove dependency on sysutils/prelink, update to 5.13-4
Summary: emulators/wine-proton: remove dependency on sysutils/prelink, update to 5.13-4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: buildisok, patch
Depends on:
Blocks:
 
Reported: 2021-01-09 09:09 UTC by Alex S
Modified: 2021-02-06 18:03 UTC (History)
4 users (show)

See Also:


Attachments
wine-proton-5.13-4.patch (2.82 KB, patch)
2021-01-09 09:09 UTC, Alex S
iwtcex: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex S 2021-01-09 09:09:32 UTC
Created attachment 221410 [details]
wine-proton-5.13-4.patch
Comment 1 Automation User 2021-01-09 13:58:50 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/239377931
Comment 2 rozhuk.im 2021-01-09 21:48:31 UTC
Works for me.

But better to add
CFLAGS+=-O2

I build all with -O3 and wine does not work proper after it, wine-proton hang on:
    frame #4: 0x000000006302e211 ntdll.so`find_drive_rootA + 3153
    frame #5: 0x0000000063031f20 ntdll.so`unix_to_nt_file_name + 80
    frame #6: 0x000000006301e218 ntdll.so`add_path_var + 56
    frame #7: 0x000000006302007f ntdll.so`get_dynamic_environment + 559
    frame #8: 0x000000007bc5168d
some how it call get_dynamic_environment in infinite loop.
Probably same required for other wine ports.
Comment 3 Alex S 2021-01-10 00:27:17 UTC
(In reply to rozhuk.im from comment #2)

> But better to add
> CFLAGS+=-O2

The default setting is already CFLAGS="-O2 -pipe  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc9 -isystem /usr/local/include -fno-strict-aliasing ". (http://beefy6.nyi.freebsd.org/data/121amd64-default/560362/logs/wine-proton-5.13.2.log)

> I build all with -O3

You know as well as anyone this a dumb thing to do.
Comment 4 rozhuk.im 2021-01-10 14:06:17 UTC
wine add many flags inside it is own build system, probably some of them with -O3 gives broken code.


No, I do not know :)
I am using system and all ports with -O3 more than 1 year and see no crashes or other annoying things.

audio/deadbeef, devel/libudev-devd only these two I alnost sure that was have negative effect from -O3.
And now wine. In past I use i386-wine-devel, but now there is no working package for current, so I build wine64.

archivers/file-roller - some times crashes, but I almost sure that this is not related to -O3.

Even security/libtasn1 failure - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252548 not related with -O3.
Comment 5 commit-hook freebsd_committer 2021-02-06 18:02:32 UTC
A commit references this bug:

Author: arrowd
Date: Sat Feb  6 18:02:10 UTC 2021
New revision: 564231
URL: https://svnweb.freebsd.org/changeset/ports/564231

Log:
  emulators/wine-proton: Update to 5.13-4

  PR:		252537
  Submitted by:	Ales S <iwtcex@gmail.com>

Changes:
  head/emulators/wine-proton/Makefile
  head/emulators/wine-proton/distinfo
  head/emulators/wine-proton/pkg-plist