Bug 252538 - emulators/libc6-shim: update to 20210109
Summary: emulators/libc6-shim: update to 20210109
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/shkhln/libc6-shim/...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-01-09 09:22 UTC by Alex S
Modified: 2021-01-10 08:53 UTC (History)
1 user (show)

See Also:


Attachments
shim-20210109.patch (1.21 KB, patch)
2021-01-09 09:22 UTC, Alex S
iwtcex: maintainer-approval+
Details | Diff
Synth test log (34.75 KB, text/plain)
2021-01-09 12:45 UTC, Alex S
no flags Details
shim-20210109.patch v2 (1.23 KB, patch)
2021-01-10 08:43 UTC, Alex S
iwtcex: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex S 2021-01-09 09:22:47 UTC
Created attachment 221411 [details]
shim-20210109.patch

The shim doesn't really have any user-facing features, so update contains bug fixes and similarly unexciting stuff.
Comment 1 Fernando Apesteguía freebsd_committer 2021-01-09 11:44:52 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A:  /tmp/252538/emulators/libc6-shim/pkg-plist: [3]: installing shared libraries, please define USE_LDCONFIG as appropriate
 /tmp/252538/emulators/libc6-shim/pkg-plist: [4]: installing shared libraries, please define USE_LDCONFIG as appropriate
 /tmp/252538/emulators/libc6-shim/pkg-plist: [5]: installing shared libraries, please define USE_LDCONFIG as appropriate
 /tmp/252538/emulators/libc6-shim/pkg-plist: [6]: installing shared libraries, please define USE_LDCONFIG as appropriate

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html


Thanks!
Comment 2 Automation User 2021-01-09 12:03:39 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/239378310
Comment 3 Alex S 2021-01-09 12:45:57 UTC
Created attachment 221419 [details]
Synth test log

(In reply to Fernando Apesteguía from comment #1)

Here's a Synth's build log, although you might as well look at the result of automated tests in comment #3.
Comment 4 Alex S 2021-01-09 12:46:45 UTC
(In reply to Alex S from comment #3)

* comment #2 :)
Comment 5 Alex S 2021-01-09 12:53:10 UTC
(In reply to Fernando Apesteguía from comment #1)

> portlint

If you insist:

% portlint -C
WARN: .../emulators/libc6-shim/pkg-plist: [3]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: .../emulators/libc6-shim/pkg-plist: [4]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: .../emulators/libc6-shim/pkg-plist: [5]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: .../emulators/libc6-shim/pkg-plist: [6]: installing shared libraries, please define USE_LDCONFIG as appropriate
0 fatal errors and 4 warnings found.

This is actually quite intentional, but I have no idea how to disable that check. Any suggestions?
Comment 6 Fernando Apesteguía freebsd_committer 2021-01-09 17:47:02 UTC
(In reply to Alex S from comment #5)

I don't know either how to disable it, but if it is intended, we are OK. Thanks for checking it out, though.
Comment 7 Alex S 2021-01-10 08:43:02 UTC
Created attachment 221436 [details]
shim-20210109.patch v2

Let's also disable Portscout's notifications while we are at it.
Comment 8 Alex S 2021-01-10 08:53:06 UTC
(In reply to Fernando Apesteguía from comment #6)

Looks like the most recent version of Portlint doesn't complain due to a new "naked so" check: https://svnweb.freebsd.org/ports/head/ports-mgmt/portlint/src/portlint.pl?r1=559405&r2=559404&pathrev=559405. Good timing, I suppose.