Created attachment 221440 [details]
patch for misc/findutils to update to 4.8.0
Update misc/findutils to 4.8.0
Release notes: https://lists.gnu.org/archive/html/bug-findutils/2021-01/msg00044.html
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/239622951
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.
/tmp/252558/misc/findutils/files/patch-configure: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
/tmp/252558/misc/findutils/files/patch-gnulib-lib-fdopendir.c: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
Created attachment 221455 [details]
Modified with ordered vars, corrected patch file, and without sig file
Thanks for patch.
After investigating a bit, I came across a few points with your patch that I would like to clarify:
- 'portlint -AC' indicated that something is wrong with files/patch-gl_lib_fdopendir.c. It turned out that this file was not created by 'make makepatch' and was also wrongly named.
- 'portclippy Makefile' (from ports-mgmt/portfmt) gives hints about the order of variables in the Makefile. I have reordered accordingly.
- It is not clear to me what the signature file is downloaded for. Surely it is not used afterwards? For now, I commented it out. If you agree, it will be removed from the Makefile and the distinfo.
- LOCALSTATDIR should point to the location where glocate finds the locate.database? This does not seem to work. glocate does not use the existing locate.database under /var/db until this is explicitly specified in the call:
glocate --database=/var/db/locate.database xyz...
(In reply to Rainer Hurling from comment #3)
Thanks for resorting the variables and refreshing/renaming the patches. I didn't touch them, as they did not need any modifications and had had this name for years; but I'm perfectly happy using this opportunity to clean things up.
> It is not clear to me what the signature file is downloaded for.
The signature is indeed not used for building. It is used (manually, at the moment) to verify that the archive really originates from the correct upstream. As this, however, is purely a maintainer task, you're right, there is no value in fetching the signature as part of a regular build, given that the archive is verified against the hashes in distinfo.
> LOCALSTATDIR should point to the location where glocate finds the locate.database? This does not seem to work. glocate does not use the existing locate.database under /var/db until this is explicitly specified in the call: [...]
LOCALSTATEDIR points indeed to the directory(!) where gupdatedb generates its database and glocate takes the database from (unless, of course, told by options to use a different database). However, glocate calls its database locatedb and not locate.database. This difference in names can be seen as a bug or as a feature, depending on whether one wants to reuse locate's database or completely independent coexistence of locate and glocate. This port always took the latter route.
(In reply to Klaus Aehlig from comment #4)
Thanks for the reply. And thanks for clarification, now I also understand the LOCALSTATEDIR var enough ;)
After removing the signature issue completely, I prepared an updated patch for a review on Phabricator . My mentors will review and it is likely to get there approval in the next couple of days :)
A commit references this bug:
Date: Mon Jan 11 21:15:40 UTC 2021
New revision: 561272
misc/findutils update to 4.8.0
Submitted by: Klaus Aehlig <email@example.com> (maintainer)
Approved by: tcberner (mentor)
Differential Revision: https://reviews.freebsd.org/D28101
Committed, thanks :)