Bug 252648 - Intel oneAPI tbb - Migrating from devel/tbb to devel/onetbb (main PR)
Summary: Intel oneAPI tbb - Migrating from devel/tbb to devel/onetbb (main PR)
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on: 252649 252651 252653 252683 252684 252686 252687 252691 252765 252785 252786 252788 252789 252790 252868 252870 252685 252688 252690 252693 252694 252695 252696 252766 252767
Blocks:
  Show dependency treegraph
 
Reported: 2021-01-13 20:34 UTC by Ganael LAPLANCHE
Modified: 2021-01-20 21:15 UTC (History)
14 users (show)

See Also:


Attachments
Patch to existing devel/tbb (1.07 KB, patch)
2021-01-13 20:45 UTC, Ganael LAPLANCHE
no flags Details | Diff
New devel/onetbb port (9.47 KB, text/plain)
2021-01-13 20:45 UTC, Ganael LAPLANCHE
no flags Details
New devel/onetbb port (v2) (10.20 KB, patch)
2021-01-18 15:15 UTC, Ganael LAPLANCHE
no flags Details | Diff
New devel/onetbb port (v2) (10.20 KB, text/plain)
2021-01-18 15:16 UTC, Ganael LAPLANCHE
no flags Details
New devel/onetbb port (v3) (10.07 KB, text/plain)
2021-01-20 18:36 UTC, Ganael LAPLANCHE
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer 2021-01-13 20:34:21 UTC
Intel oneAPI tbb (formerly known as Intel tbb) 2021.1 has been released and has deprecated several interfaces over tbb 2020, see:

 https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-threading-building-blocks-release-notes.html

and:

  https://software.intel.com/content/www/us/en/develop/articles/tbb-revamp.html

As a consequence, updating devel/tbb in-place is not possible because most of our dependent ports break.

Instead, we will introduce a new port called devel/onetbb (the new name of the library) that will hold new versions of the library. Find attached to that PR expected patches for devel/tbb and devel/onetbb.

The old port, devel/tbb will be kept for a certain amount of time and removed in the future.

We will have to migrate and patch each dependent port before committing the changes alltogether. That PR will help synchronize the migration by attaching a blocking PR for each failing port. 

See also this thread on ports@:

https://lists.freebsd.org/pipermail/freebsd-ports/2021-January/120010.html

Stay tuned!
Comment 1 Ganael LAPLANCHE freebsd_committer 2021-01-13 20:45:27 UTC
Created attachment 221542 [details]
Patch to existing devel/tbb
Comment 2 Ganael LAPLANCHE freebsd_committer 2021-01-13 20:45:57 UTC
Created attachment 221543 [details]
New devel/onetbb port
Comment 3 Yuri Victorovich freebsd_committer 2021-01-17 19:44:11 UTC
The upstream needs to fix this.
Comment 4 Yuri Victorovich freebsd_committer 2021-01-17 19:45:46 UTC
Sorry, wrong bug#. -)
Comment 5 Shane 2021-01-18 09:29:39 UTC
On my system I have devel/hwloc installed (there is also devel/hwloc2) so when I build from ports tree I get extra libs built -

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libtbbbind.so
Error: Orphaned: lib/libtbbbind.so.3
Error: Orphaned: lib/libtbbbind.so.3.1
Comment 6 Ganael LAPLANCHE freebsd_committer 2021-01-18 15:13:45 UTC
Hello Shane,

Good catch, thanks! The port has picked up legacy hwloc and built additional libtbbbind.

I've updated the patch to depend on newer devel/hwloc2 and disabled detection of devel/hwloc.

Can you check again please ?
Comment 7 Ganael LAPLANCHE freebsd_committer 2021-01-18 15:15:03 UTC
Created attachment 221708 [details]
New devel/onetbb port (v2)
Comment 8 Ganael LAPLANCHE freebsd_committer 2021-01-18 15:16:18 UTC
Created attachment 221709 [details]
New devel/onetbb port (v2)
Comment 9 Shane 2021-01-19 02:24:53 UTC
The build is fine, but I would change the lib name for the hwloc. If hwloc is installed the lib matches for dependencies but the configure fails.

Both ports have libhwloc.so, while hwloc has libhwloc.so.5 and hwloc2 has libhwloc.so.15
Comment 10 Ganael LAPLANCHE freebsd_committer 2021-01-19 11:18:26 UTC
Right, I'll fix that, thanks!
Comment 11 Greg V 2021-01-20 13:25:33 UTC
Please remove ONLY_FOR_ARCHS, :noninja, and MAKE_JOBS_UNSAFE.

And add CMAKE_ARGS+=-DTBB_STRICT:BOOL=FALSE to disable Werror, because there's e.g. an unused argument warning for '-MD' on aarch64.

With these changes, builds fine on aarch64.
Comment 12 Ganael LAPLANCHE freebsd_committer 2021-01-20 18:36:48 UTC
Created attachment 221772 [details]
New devel/onetbb port (v3)

Patch updated, thanks!