Bug 252653 - Making databases/tiledb depend on onetbb
Summary: Making databases/tiledb depend on onetbb
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 252648
  Show dependency treegraph
 
Reported: 2021-01-13 21:42 UTC by Ganael LAPLANCHE
Modified: 2021-01-27 17:07 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)
martymac: maintainer-feedback? (sunpoet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-01-13 21:42:45 UTC
Hello,

As a maintainer of databases/tiledb, could you have a look at PR #252648:

  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648

In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run:

  http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-13_17h15m06s

and error logs:

http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-13_17h15m06s/logs/errors/tiledb-2.1.6.log

/usr/bin/c++ -DFMT_SHARED -DHAVE_TBB -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTILEDB_CORE_OBJECTS_EXPORTS -DTILEDB_STATS -D_FILE_OFFSET_BITS=64 -I/wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/.. -I/wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../tiledb/sm/c_api -I/wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../external/include -I/wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../external/include/bitshuffle -I/wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../external/include/blosc -I/wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../tiledb/sm/cpp_api -Itiledb -O2 -pipe -DSPDLOG_FMT_EXTERNAL=1 -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -O2 -pipe -DSPDLOG_FMT_EXTERNAL=1 -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include -fPIC -fvisibility=hidden -Wall -Wextra -DNDEBUG -O3 -mavx2 -std=c++11 -MD -MT tiledb/CMakeFiles/TILEDB_CORE_OBJECTS.dir/sm/array/array.cc.o -MF tiledb/CMakeFiles/TILEDB_CORE_OBJECTS.dir/sm/array/array.cc.o.d -o tiledb/CMakeFiles/TILEDB_CORE_OBJECTS.dir/sm/array/array.cc.o -c /wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/sm/array/array.cc
In file included from /wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/sm/array/array.cc:34:
In file included from /wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../tiledb/sm/array_schema/array_schema.h:41:
In file included from /wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../tiledb/sm/filter/filter_pipeline.h:40:
In file included from /wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../tiledb/sm/filter/filter.h:36:
/wrkdirs/usr/ports/databases/tiledb/work/TileDB-2.1.6/tiledb/../tiledb/sm/config/config.h:37:10: fatal error: 'tbb/task_scheduler_init.h' file not found
#include <tbb/task_scheduler_init.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ?

To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648.

Thanks for your contribution,
Best regards,

Ganael.
Comment 1 Po-Chuan Hsieh freebsd_committer freebsd_triage 2021-01-26 19:32:00 UTC
TBB has been disabled in r562732 as upstream changed to their own internal threadpool implementation that uses standard C++ threading.
Thanks!
Comment 2 Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-01-27 17:07:02 UTC
Thanks Sunpoet!