Bug 252686 - Making devel/ikos depend on onetbb
Summary: Making devel/ikos depend on onetbb
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/NASA-SW-VnV/ikos/i...
Keywords:
Depends on:
Blocks: 252648
  Show dependency tree / graph
 
Reported: 2021-01-14 21:36 UTC by Ganael LAPLANCHE
Modified: 2022-12-07 06:56 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)
martymac: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer 2021-01-14 21:36:51 UTC 
Hello,

As a maintainer of devel/ikos, could you have a look at PR #252648:

  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648

In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run:

  http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-13_22h35m17s

and error logs:

http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-13_22h35m17s/logs/errors/ikos-3.0_3.log

CMake Error at cmake/FindTBB.cmake:186 (file):
  file failed to open for reading (No such file or directory):
    /usr/local/include/tbb/tbb_stddef.h

Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ?

To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648.

Thanks for your contribution,
Best regards,

Ganael.
Comment 1 Yuri Victorovich freebsd_committer 2021-01-14 23:01:31 UTC 
The upstream needs to fix this.
Comment 2 Yuri Victorovich freebsd_committer 2022-12-06 17:21:30 UTC 
Fixed.
Comment 3 commit-hook freebsd_committer 2022-12-06 17:21:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2242eb825c0d5389b02c623938f427649d7fc34f

commit 2242eb825c0d5389b02c623938f427649d7fc34f
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-12-06 15:41:19 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-12-06 17:21:02 +0000

    devel/ikos: Update 3.0 -> 3.1

    PR:             252686

 devel/ikos/Makefile  | 9 +++++----
 devel/ikos/distinfo  | 6 +++---
 devel/ikos/pkg-plist | 8 ++++----
 3 files changed, 12 insertions(+), 11 deletions(-)
Comment 4 Ganael LAPLANCHE freebsd_committer 2022-12-07 06:39:37 UTC 
Thanks Yuri!
Comment 5 Yuri Victorovich freebsd_committer 2022-12-07 06:56:53 UTC 
(In reply to Ganael LAPLANCHE from comment #4)

You are welcome, Ganael!