Bug 252694 - Making science/madness depend on onetbb
Summary: Making science/madness depend on onetbb
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL: https://github.com/m-a-d-n-e-s-s/madn...
Keywords:
Depends on:
Blocks: 252648
  Show dependency tree / graph
 
Reported: 2021-01-14 22:24 UTC by Ganael LAPLANCHE
Modified: 2025-05-13 14:17 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)
martymac: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-01-14 22:24:04 UTC 
Hello,

As a maintainer of science/madness, could you have a look at PR #252648:

  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648

In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run:

  http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-13_22h35m17s

and error logs:

http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-13_22h35m17s/logs/errors/madness-0.10.1.20180823_11.log

CMake Error at cmake/modules/FindTBB.cmake:103 (file):
  file failed to open for reading (No such file or directory):

    /usr/local/include/tbb/tbb_stddef.h
Call Stack (most recent call first):
  external/tbb.cmake:2 (find_package)
  CMakeLists.txt:522 (include)

-- Could NOT find TBB: Found unsuitable version ".", but required is at least "4.3.5" (found /usr/local/lib/libtbb.so, )

Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ?

To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648.

Thanks for your contribution,
Best regards,

Ganael.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-01-15 18:35:58 UTC 
Made TBB optional and OFF by default.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-01-15 18:36:09 UTC 
A commit references this bug:

Author: yuri
Date: Fri Jan 15 18:36:00 UTC 2021
New revision: 561663
URL: https://svnweb.freebsd.org/changeset/ports/561663

Log:
  science/madness: Make TBB dependency optional, OFF by default until the upstream fixes oneTBB support

  PR:		252694

Changes:
  head/science/madness/Makefile
Comment 3 Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-01-16 14:07:11 UTC 
Thanks!
Comment 4 Ganael LAPLANCHE freebsd_committer freebsd_triage 2024-11-08 12:18:42 UTC 
Hello Yuri,

The code of Madness seems to support oneTbb. Could you try to update the port please ?

Thanks in advance,
Best regards,

Ganael.
Comment 5 Ganael LAPLANCHE freebsd_committer freebsd_triage 2024-11-12 11:45:48 UTC 
I mean new *upstream* code of Madness seems to support oneTbb, see:
https://github.com/m-a-d-n-e-s-s/madness/blob/master/INSTALL.md?plain=1#L31
Comment 6 Ganael LAPLANCHE freebsd_committer freebsd_triage 2025-05-13 14:17:02 UTC 
Hello Yuri,

Have you had time to take a look at that request ?

misc/usd (PR 282627) and science/madness (PR 252694) are the only remaining consumers of devel/tbb. 

Updating those 2 ports would allow closing PR 252648 and remove old devel/tbb from the tree.

Thanks in advance,

Ganael.