Bug 252711 - ppi.h PPISEPPA error
Summary: ppi.h PPISEPPA error
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.2-STABLE
Hardware: amd64 Any
: --- Affects Many People
Assignee: Mark Johnston
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-15 13:09 UTC by Eugene
Modified: 2021-01-19 00:48 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene 2021-01-15 13:09:03 UTC
Header files /usr/src/sys/dev/ppbus/ppi.h and /usr/include/dev/ppbus/ppi.h contains an error.

This path fix it:


--- ppi.h       2020-10-25 17:18:11.737811000 +0800
+++ ppi.h.patched       2021-01-15 20:58:07.407729000 +0800
@@ -51,6 +51,6 @@
 #define        PPISFIFO        _IOW('P', 21, u_int8_t)
 
 #define        PPIGEPPA        _IOR('P', 22, u_int8_t)
-#define        PPISEPPA        _IOR('P', 23, u_int8_t)
+#define        PPISEPPA        _IOW('P', 23, u_int8_t)
 
 #endif
Comment 1 Mark Johnston freebsd_committer 2021-01-15 15:00:56 UTC
Looks right.
Comment 2 commit-hook freebsd_committer 2021-01-19 00:46:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a45d90561696e7a5c76e38c6bf715e6190d2ca07

commit a45d90561696e7a5c76e38c6bf715e6190d2ca07
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2021-01-19 00:44:42 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2021-01-19 00:44:42 +0000

    ppbus: Fix the direction of the PPISEPPA ioctl

    PR:             252711
    Submitted by:   Eugene <merfi@nearly.ru>

 sys/dev/ppbus/ppi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Mark Johnston freebsd_committer 2021-01-19 00:48:09 UTC
Thanks for the patch.