Hello, As a maintainer of graphics/instant-meshes, could you have a look at PR #252648: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648 In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run: http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-13_22h35m17s and error logs: http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-15_15h54m22s/logs/errors/instant-meshes-0.0.42_10.log /wrkdirs/usr/ports/graphics/instant-meshes/work/instant-meshes-0.0-42-g4a083f4/src/main.cpp:173:29: error: expected ';' after expression tbb::task_scheduler_init init(nprocs == -1 ? tbb::task_scheduler_init::automatic : nprocs); ^ ; /wrkdirs/usr/ports/graphics/instant-meshes/work/instant-meshes-0.0-42-g4a083f4/src/main.cpp:173:10: error: no member named 'task_scheduler_init' in namespace 'tbb' tbb::task_scheduler_init init(nprocs == -1 ? tbb::task_scheduler_init::automatic : nprocs); ~~~~~^ /wrkdirs/usr/ports/graphics/instant-meshes/work/instant-meshes-0.0-42-g4a083f4/src/main.cpp:173:55: error: no member named 'task_scheduler_init' in namespace 'tbb' tbb::task_scheduler_init init(nprocs == -1 ? tbb::task_scheduler_init::automatic : nprocs); ~~~~~^ 3 errors generated. Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ? To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648. You will also need suitesparse patches from PR #252651 as suitesparse does not build with oneTbb. Thanks for your contribution, Best regards, Ganael.
Created attachment 221739 [details] instant-meshes-tbb.patch Looks like the removed task API is about the only thing it uses from TBB. Let's just stop unbundling and use the bundled (CMake-ified fork of) TBB as intended. Builds very quickly actually.
Hello, Thanks, I'll test and (if OK) commit the patch during the big switch. Best regards, Ganael.
(In reply to Ganael LAPLANCHE from comment #2) This one can actually go in early, since it removes the dependency altogether
A commit references this bug: Author: martymac Date: Wed Jan 20 11:38:16 UTC 2021 New revision: 562132 URL: https://svnweb.freebsd.org/changeset/ports/562132 Log: Use internal tbb to facilitate oneTbb transition PR: 252766 Submitted by: greg@unrelenting.technology Approved by: greg@unrelenting.technology (maintainer) Changes: head/graphics/instant-meshes/Makefile head/graphics/instant-meshes/distinfo head/graphics/instant-meshes/files/patch-CMakeLists.txt
Great, I have committed the changes, then. Thanks again :)