Bug 252848 - multimedia/libdvdcss: Build error with default options and devel/doxygen installed
Summary: multimedia/libdvdcss: Build error with default options and devel/doxygen inst...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-20 07:53 UTC by Rainer Hurling
Modified: 2021-01-20 11:26 UTC (History)
4 users (show)

See Also:

Attachments
patch to disable usage of doxygen, when unselected (340 bytes, patch)
2021-01-20 07:53 UTC, Rainer Hurling 		no flags Details | Diff
handle doxygen right way™ (1.52 KB, patch)
2021-01-20 08:22 UTC, Dima Panov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2021-01-20 07:53:10 UTC 
Created attachment 221759 [details]
patch to disable usage of doxygen, when unselected

Even if OPTION DOXYGEN is disabled (default), multimedia/libdvdcss (1.4.2_1) finds an already installed devel/doxygen in its configure process:

checking for doxygen... /usr/local/bin/doxygen


The build then breaks with the following message:

[..snip..]
libtool: link: ranlib .libs/libdvdcss.a
libtool: link: ( cd ".libs" && rm -f "libdvdcss.la" && ln -s "../libdvdcss.la" "libdvdcss.la" )
doxygen 
error: Doxyfile not found and no input file specified!
Doxygen version 1.9.0
Copyright Dimitri van Heesch 1997-2019
...


The attached patch disables the doxygen build in the configure file.


Please note, that multimedia/libdvdcss also fails with enabled OIPTION DOXYGEN! The patch has no solution for that problem.
Comment 1 Dima Panov freebsd_committer freebsd_triage 2021-01-20 08:22:03 UTC 
Created attachment 221761 [details]
handle doxygen right way™

Rainer, your patch is incorrect :) 

As maintainer of doxygen grab this pr to prepare commit
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2021-01-20 08:39:59 UTC 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252321
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-01-20 08:48:53 UTC 
A commit references this bug:

Author: fluffy
Date: Wed Jan 20 08:48:32 UTC 2021
New revision: 562120
URL: https://svnweb.freebsd.org/changeset/ports/562120

Log:
  multimedia/libdvdcss: unbreak wit recent doxygen

  With hat:	ports-secteam
  PR:		252848
  Suggested by:	VVD in PR 252321
  MFH:		2021Q1

Changes:
  head/multimedia/libdvdcss/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-01-20 08:51:55 UTC 
A commit references this bug:

Author: fluffy
Date: Wed Jan 20 08:51:39 UTC 2021
New revision: 562121
URL: https://svnweb.freebsd.org/changeset/ports/562121

Log:
  MFH: r562095 r562120

  Fix potential buffer overflow.

  Along the way improve port Makefile

  PR:	252321
  Submitted by:	daniel.engberg.lists@pyret.net

  multimedia/libdvdcss: unbreak wit recent doxygen

  With hat:	ports-secteam
  PR:		252848
  Suggested by:	VVD in PR 252321

Changes:
_U  branches/2021Q1/
  branches/2021Q1/multimedia/libdvdcss/Makefile
  branches/2021Q1/multimedia/libdvdcss/files/
Comment 5 Dima Panov freebsd_committer freebsd_triage 2021-01-20 08:59:30 UTC 
Fixed!
Comment 6 Rainer Hurling freebsd_committer freebsd_triage 2021-01-20 11:26:05 UTC 
(In reply to Dima Panov from comment #1)

More incomplete than incorrect, since it correctly prevented the integration of doxygen for default settings ;)

Anyway, your patch is correct and complete and now works with doxygen :D


Thanks for the quick fix!