Bug 252932 - ports-mgmt/portfmt: Update to g20200924
Summary: ports-mgmt/portfmt: Update to g20200924
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-01-23 05:21 UTC by Naram Qashat
Modified: 2021-01-23 18:17 UTC (History)
2 users (show)

See Also:


Attachments
portfmt-g20200924.patch (1.39 KB, patch)
2021-01-23 05:21 UTC, Naram Qashat
cyberbotx: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2021-01-23 05:21:07 UTC
Created attachment 221830 [details]
portfmt-g20200924.patch

* Update to g20200924 (git commit 57e2a01dedeaf353bced82e76942abeaed205b14)
* Remove USE_LDCONFIG (portlint says it was unnecessary because there are no libraries being installed in the lib*.so.[0-9] format)
* Update distinfo

No changelog but changed can be found through this: https://github.com/t6/portfmt/compare/11fdf0b5dcd9d7e5ca0686bcaca056d99b1d3688...57e2a01dedeaf353bced82e76942abeaed205b14

Tested in poudriere for 11-i386, 11-amd64, 12-i386 and 12-amd64. Passes portlint (although it complains about pkg-descr containing 26 lines).

I would offer to take maintainership, but the GitHub repo for this has been marked as archived and read-only.
Comment 1 Automation User 2021-01-23 05:42:06 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/245798743
Comment 2 Rainer Hurling freebsd_committer 2021-01-23 08:10:10 UTC
Hi Naram,

Thanks for the patch!

You gave maintainer-approval: Do you mean to take maintainership for the port ;)  That would be great.
Comment 3 Dmitri Goutnik freebsd_committer 2021-01-23 11:09:38 UTC
(In reply to Naram Qashat from comment #0)
Hi,

> * Remove USE_LDCONFIG

I don't think this is correct. portfmt uses plugins (plugin.*.so) which will break without this option.
Comment 4 Rainer Hurling freebsd_committer 2021-01-23 11:29:57 UTC
(In reply to Dmitri Goutnik from comment #3)

Hi Naram,

I think Dmitri is right.

I will put back USE_LDCONFIG=yes in the Makefile. Do you agree?
Comment 5 Naram Qashat 2021-01-23 15:58:08 UTC
I wasn't aware that portlint was misreporting that, so yes, putting it back is fine.

As for maintainership, I would agree to take it, but as I mentioned in the initial report, the project appears to have become abandoned upstream. This might be the last update the port ever gets.
Comment 6 Rainer Hurling freebsd_committer 2021-01-23 16:46:46 UTC
(In reply to Naram Qashat from comment #5)

Oops, sorry. I must have missed the part, where you mentioned maintainership and archived github project in your initial description.

So I will therefore leave the maintainership on ports@ as you originally intended. If necessary, this can still be changed ;)
Comment 7 commit-hook freebsd_committer 2021-01-23 18:15:23 UTC
A commit references this bug:

Author: rhurlin
Date: Sat Jan 23 18:14:51 UTC 2021
New revision: 562407
URL: https://svnweb.freebsd.org/changeset/ports/562407

Log:
  ports-mgmt/portfmt: Update to g20200924

  Changelog: https://github.com/t6/portfmt/compare/11fdf0b5dcd9d7e5ca0686bcaca056d99b1d3688...57e2a01dedeaf353bced82e76942abeaed205b14

  The GitHub repo for portfmt has been marked as archived and
  read-only. So probably the current version is the last one.

  PR:		252932
  Submitted by:	Naram Qashat <cyberbotx@cyberbotx.com>
  Approved by:	arrowd, tcberner (mentors, implicit)

Changes:
  head/ports-mgmt/portfmt/Makefile
  head/ports-mgmt/portfmt/distinfo
Comment 8 Rainer Hurling freebsd_committer 2021-01-23 18:17:24 UTC
Committed, thanks :)