Bug 252957 - audio/pulseaudio: update the port to 14.2
Summary: audio/pulseaudio: update the port to 14.2
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-desktop (Team)
URL: https://github.com/freebsd/freebsd-po...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-23 22:47 UTC by Matthias Apitz
Modified: 2021-01-31 12:20 UTC (History)
5 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
output of: svn diff audio/pulseaudio (3.39 KB, patch)
2021-01-23 22:50 UTC, Matthias Apitz
no flags Details | Diff
new patch, output off: svn diff audio/pulseaudio (4.06 KB, patch)
2021-01-24 10:45 UTC, Matthias Apitz
no flags Details | Diff
new patch, fixed pkg-plist issue, output of: svn diff audio/pulseaudio (4.69 KB, patch)
2021-01-31 12:20 UTC, Matthias Apitz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Apitz 2021-01-23 22:47:03 UTC
The current port is based on the upstream version 13.0 from 2019-09-13 and should be updated to 14.2 from 2021-01-16. I will attach a 'svn diff audio/pulseaudio'.
Comment 1 Matthias Apitz 2021-01-23 22:50:28 UTC
Created attachment 221857 [details]
output of: svn diff audio/pulseaudio
Comment 2 daniel.engberg.lists 2021-01-23 23:31:28 UTC
PORTVERSION --> DISTVERSION
See Porters Handbook, "Table 5.2. Package Naming Examples"

PORTREVISION should be removed
MASTER_SITES=http://freedesktop.org/software/pulseaudio/releases/ shoud be https://freedesktop.org/software/pulseaudio/releases/ (redirects)

CPPFLAGS + LDFLAGS should be replaced by USES= localbase:ldflags

Can you have a look at converting this port to using meson instead?

Does it pass poudriere?
Comment 3 Matthias Apitz 2021-01-24 09:08:06 UTC
The original (svn head) ports Makefile has set --disable-udev which leads to not compiling the module module-udev-detect.so. After deleting this line in the Makefile, the module compiles fine but says on

pacmd load-module module-udev-detect

in /var/log/messages:

Jan 24 00:52:22 c720-r368166 pulseaudio[85187]: [(null)] ltdl-bind-now.c: No se pudo abrir el módulo /usr/local/lib/pulse-14.2/modules/module-udev-detect.so: /usr/local/lib/pulse-14.2/modules/module-udev-detect.so: Undefined symbol """

"inotify_init1" seems to be a Linux sys or function call not implemented in FreeBSD.
Comment 4 Tobias C. Berner freebsd_committer 2021-01-24 09:11:28 UTC
(In reply to daniel.engberg.lists from comment #2)

Thanks a lot for the patch -- but converting it to meson too would be great :)
Comment 5 Matthias Apitz 2021-01-24 10:45:10 UTC
Created attachment 221870 [details]
new patch, output off: svn diff audio/pulseaudio

This patch:
1) cleans the raised issues in the Makefile
2) was tested in poudriere:
...
===>  Building package for pulseaudio-14.2
file sizes/checksums   [224]: ... done
packing files          [224]: ... done
packing directories      [0]: . done
===========================================================================
=>> Cleaning up wrkdir
===>  Cleaning for pulseaudio-14.2
build of audio/pulseaudio | pulseaudio-14.2 ended at Sun Jan 24 11:33:47 CET 2021
build time: 00:01:08

Re/ meson: I never used this, so I let this to MAINTAINER of the port.
Comment 6 Jan Beich freebsd_committer 2021-01-31 11:22:58 UTC
Comment on attachment 221870 [details]
new patch, output off: svn diff audio/pulseaudio

> -WEBRTC_AEC_LIB_DEPENDS=	libwebrtc_audio_processing.so:audio/webrtc-audio-processing0
> +WEBRTC_AEC_LIB_DEPENDS=	libwebrtc_audio_processing.so:audio/webrtc-audio-processing

Why? Upstream hasn't switched yet, see https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/395

$ poudriere testport -j 122amd64 audio/pulseaudio
[...]
===>   pulseaudio-14.2 depends on shared library: libwebrtc_audio_processing.so - not found
===>   Installing existing package /packages/All/webrtc-audio-processing-1.0_1.txz
Installing webrtc-audio-processing-1.0_1...
`-- Installing abseil-20200923.3...
`-- Extracting abseil-20200923.3: .......... done
Extracting webrtc-audio-processing-1.0_1: .......... done
===>   pulseaudio-14.2 depends on shared library: libwebrtc_audio_processing.so - not found
*** Error code 1
Comment 7 Jan Beich freebsd_committer 2021-01-31 11:24:30 UTC
$ make check-plist
[...]
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/locale/bg/LC_MESSAGES/pulseaudio.mo
Error: Orphaned: share/locale/kk/LC_MESSAGES/pulseaudio.mo
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
Comment 8 Matthias Apitz 2021-01-31 11:44:45 UTC
(In reply to Jan Beich from comment #7)

the change re/ WEBRTC_AEC_LIB_DEPENDS was not introduced by me; before starting on the work of the update, I fetched the most recent version out of SVN:

root@c720-r368166:/usr/ports/audio/pulseaudio # svn info
Path: .
Working Copy Root Path: /usr/ports
URL: svn://svn.freebsd.org/ports/head/audio/pulseaudio
Relative URL: ^/head/audio/pulseaudio
Repository Root: svn://svn.freebsd.org/ports
Repository UUID: 35697150-7ecd-e111-bb59-0022644237b5
Revision: 562403
Node Kind: directory
Schedule: normal
Last Changed Author: jbeich
Last Changed Rev: 557409
Last Changed Date: 2020-12-10 03:42:18 +0100 (Thu, 10 Dec 2020)

root@c720-r368166:/usr/ports/audio/pulseaudio # grep WEBRTC_AEC_LIB_DEPENDS Makefile 
WEBRTC_AEC_LIB_DEPENDS=	libwebrtc_audio_processing.so:audio/webrtc-audio-processing
Comment 9 Matthias Apitz 2021-01-31 12:20:30 UTC
Created attachment 222036 [details]
new patch, fixed pkg-plist issue, output of: svn diff audio/pulseaudio