Bug 253057 - audio/libsamplerate: Update to 0.2.1 and convert to CMake
Summary: audio/libsamplerate: Update to 0.2.1 and convert to CMake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL: https://github.com/libsndfile/libsamp...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-28 02:48 UTC by Daniel Engberg
Modified: 2021-02-10 17:08 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Patch for libsamplerate (9.40 KB, patch)
2021-01-28 02:48 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-01-28 02:48:20 UTC 
Created attachment 221978 [details]
Patch for libsamplerate

Update libsamplerate to 0.2.1
Convert to CMake

Compile and tested on FreeBSD 13.0-CURRENT main-c1-g63f93c7e1 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-10 12:14:00 UTC 
Moin moin 

I think you could use CMAKE_DISABLE_FIND_PACKAGE_${foo} instead of some of the patches there.


E.g. 
CMAKE_ON+=CMAKE_DISABLE_FIND_PACKAGE_FLAC

Otherwise, it looks fine to me.

mfg Tobias
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-02-10 12:34:25 UTC 
Wouldn't that make INTERFACE_LINK_LIBRARIES unhappy?
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-10 12:40:40 UTC 
Indeed, I overlooked that part :)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-02-10 12:57:10 UTC 
I've asked upstream about this issue but I'm a bit confused regarding the reply
https://github.com/libsndfile/libsamplerate/issues/146
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-10 17:07:54 UTC 
Thanks for following up upstream with that issue -- I will commit it as is for now, and keep track of the issue upstream.


mfg Tobias
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-02-10 17:08:12 UTC 
A commit references this bug:

Author: tcberner
Date: Wed Feb 10 17:07:45 UTC 2021
New revision: 564879
URL: https://svnweb.freebsd.org/changeset/ports/564879

Log:
  audio/libsamplerate: Update to 0.2.1

  - The build system has been switched to cmake

  Release Notes:
          https://github.com/libsndfile/libsamplerate/releases/tag/0.2.1

  PR:		253057
  Submitted by:	daniel.engberg.lists@pyret.net

Changes:
  head/audio/libsamplerate/Makefile
  head/audio/libsamplerate/distinfo
  head/audio/libsamplerate/files/patch-cmake_FindSndFile.cmake
  head/audio/libsamplerate/files/patch-examples_CMakeLists.txt
  head/audio/libsamplerate/files/patch-examples_audio__out.c
  head/audio/libsamplerate/files/patch-src_samplerate.h
  head/audio/libsamplerate/pkg-plist