Bug 253059 - news/fidogate: Update to 5.10
Summary: news/fidogate: Update to 5.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
Depends on:
Reported: 2021-01-28 08:46 UTC by Sergey Anokhin
Modified: 2021-01-28 15:10 UTC (History)
1 user (show)

See Also:

Patch for existing port (1.01 KB, patch)
2021-01-28 08:46 UTC, Sergey Anokhin
no flags Details | Diff
Patch for existing port (branch staging) (1.23 KB, patch)
2021-01-28 09:06 UTC, Sergey Anokhin
no flags Details | Diff
patch using github to access a commit between two versions (4.08 KB, patch)
2021-01-28 12:08 UTC, Rainer Hurling
rhurlin: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Anokhin 2021-01-28 08:46:18 UTC
Created attachment 221980 [details]
Patch for existing port

Hi All,

New port version, the diff is attached.
Pls commit this.

Comment 1 Sergey Anokhin 2021-01-28 09:06:22 UTC
Created attachment 221981 [details]
Patch for existing port (branch staging)

Correct patch file
Comment 2 Rainer Hurling freebsd_committer 2021-01-28 12:08:05 UTC
Created attachment 221986 [details]
patch using github to access a commit between two versions

Hi Sergey,

Thanks for your patch. As far as I understand you want to use v5.10 with 3 additional versions from branch staging (#1c1fd41), right?

For this, there is a good description in the Porters Handbook, example 19 [1]. It describes, how the concrete commit (tag) can be used to find a good version number. Here it is:

# git describe --tags 1c1fd41

This means, tag 1c1fd41 is three commit after v5.10. I changed the entries in your Makefile like this and created a new distinfo. While here, I also sorted the Makefile vars, like suggested by portclippy.

Could you please have a look and give some feedback, if these changes are ok for you?

[1] https://docs.freebsd.org/en/books/porters-handbook/#makefile-master_sites-github-ex5
Comment 3 Sergey Anokhin 2021-01-28 12:55:09 UTC
(In reply to Rainer Hurling from comment #2)

Hi Rainer,

Thank you for the feedback and for the port improving.
We discussed with fidogate developer the current version. The problem was in some user cases that had crashes. Needed fixes were made in the staging branch, but the developer believes that these fixes are not enough to create new release (too few changes), so this is a cause that me added link to the commit.

Let me check your final version of the patch on my system. I'll send you report within 15 mins.

Comment 4 Sergey Anokhin 2021-01-28 13:16:00 UTC
All looks fine, the patch was tested. The software looks good.
Comment 5 Rainer Hurling freebsd_committer 2021-01-28 13:44:10 UTC
Thanks for your explanations and the tests.

I just opened review D28400 on Phabricator, to get approval from my mentors.
Comment 6 commit-hook freebsd_committer 2021-01-28 15:09:33 UTC
A commit references this bug:

Author: rhurlin
Date: Thu Jan 28 15:08:42 UTC 2021
New revision: 563140
URL: https://svnweb.freebsd.org/changeset/ports/563140

  news/fidogate: Update to 5.10-3

  Update port to release v5.10 [1] plus additional commits from
  branch 'staging' [2]. All commits after the release are fixes.

  - fidogate.service: [ is put back
  - fidogate.service: full paths for commands
  - rfc2ftn: fix mime unpacking if recipients
    given in command line
  - rfc2ftn: Fix SIGSEGV on list_free
  - mime: fix memleak on multipart decoding
  - rfc2ftn: Fix for test019: check crash in

  [1] https://github.com/ykaliuta/fidogate/releases/tag/v5.10
  [2] https://github.com/ykaliuta/fidogate/commits/staging

  PR:		253059
  Submitted by:	Sergey Anokhin <admin@5034.ru> (maintainer)
  Approved by:	arrowd (mentor)
  Differential Revision:	https://reviews.freebsd.org/D28400

Comment 7 Rainer Hurling freebsd_committer 2021-01-28 15:10:42 UTC
Committed, thanks :)