Bug 253169 - ipfw: sigbus when ext6hdr option is omitted
Summary: ipfw: sigbus when ext6hdr option is omitted
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 13.0-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-01 18:58 UTC by Evgeniy Khramtsov
Modified: 2021-02-04 14:23 UTC (History)
1 user (show)

See Also:


Attachments
proposed patch (356 bytes, patch)
2021-02-01 18:58 UTC, Evgeniy Khramtsov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Khramtsov 2021-02-01 18:58:31 UTC
Created attachment 222081 [details]
proposed patch

ipfw(8) crashes when ext6hdr option is omitted:

# ipfw add 11 pass log ext6hdr
Bus error
Comment 1 Kristof Provost freebsd_committer 2021-02-01 18:59:40 UTC
See also https://reviews.freebsd.org/D28447
Comment 2 commit-hook freebsd_committer 2021-02-01 20:27:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=682c31db4ecfb8fc6cac0e8ad4945c03379ea3d1

commit 682c31db4ecfb8fc6cac0e8ad4945c03379ea3d1
Author:     Evgeniy Khramtsov <2khramtsov@gmail.com>
AuthorDate: 2021-02-01 19:03:57 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-02-01 20:25:11 +0000

    ipfw(8) crashes when ext6hdr option is omitted

    Verify that the option is passed, error out if it's not.
    The problem can be trivially triggered with `ipfw add allow ext6hdr`.

    PR:             253169
    Reviewed by:    kp@
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D28447

 sbin/ipfw/ipfw2.c | 1 +
 1 file changed, 1 insertion(+)
Comment 3 commit-hook freebsd_committer 2021-02-04 14:23:42 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=620455079f47a9d7361b46b965abf273ac6787de

commit 620455079f47a9d7361b46b965abf273ac6787de
Author:     Evgeniy Khramtsov <2khramtsov@gmail.com>
AuthorDate: 2021-02-01 19:03:57 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-02-04 14:22:45 +0000

    ipfw(8) crashes when ext6hdr option is omitted

    Verify that the option is passed, error out if it's not.
    The problem can be trivially triggered with `ipfw add allow ext6hdr`.

    PR:             253169
    Reviewed by:    kp@
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D28447

    (cherry picked from commit 682c31db4ecfb8fc6cac0e8ad4945c03379ea3d1)

 sbin/ipfw/ipfw2.c | 1 +
 1 file changed, 1 insertion(+)
Comment 4 commit-hook freebsd_committer 2021-02-04 14:23:44 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d2eeacf7728a04ee04be8a69b2b1bf375ff24994

commit d2eeacf7728a04ee04be8a69b2b1bf375ff24994
Author:     Evgeniy Khramtsov <2khramtsov@gmail.com>
AuthorDate: 2021-02-01 19:03:57 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-02-04 08:13:46 +0000

    ipfw(8) crashes when ext6hdr option is omitted

    Verify that the option is passed, error out if it's not.
    The problem can be trivially triggered with `ipfw add allow ext6hdr`.

    PR:             253169
    Reviewed by:    kp@
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D28447

    (cherry picked from commit 682c31db4ecfb8fc6cac0e8ad4945c03379ea3d1)

 sbin/ipfw/ipfw2.c | 1 +
 1 file changed, 1 insertion(+)