Bug 253214 - www/serf: on recent head with KTLS causes subversion to hang
Summary: www/serf: on recent head with KTLS causes subversion to hang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-03 16:04 UTC by Guido Falsi
Modified: 2021-02-04 11:39 UTC (History)
1 user (show)

See Also:
lev: maintainer-feedback+
jbeich: merge-quarterly?

Attachments
patch (1.19 KB, patch)
2021-02-03 16:04 UTC, Guido Falsi 		madpilot: maintainer-approval? (lev)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2021-02-03 16:04:09 UTC 
Created attachment 222115 [details]
patch

A recent commit to head enables KTLS in base openssl by default for amd64.

This change uncovered what appears to be a bug in serf. I reported it on the mailing lists and jhb provided a patch for base embedded serf:

https://lists.freebsd.org/pipermail/dev-commits-src-all/2021-February/002195.html

This bug report is just a porting of his patch to the ports tree version of serf.

The base bug is being tracked at bug #253135
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2021-02-03 16:08:53 UTC 
^Triage: fix Summary and assign to maintainer.

To submitter: please note that bugmeister@ is discouraging the use of the patch Keyword (and [patch] convention) in favor of deriving this from the metadata w/rt Attachments.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-02-03 20:35:56 UTC 
A commit references this bug:

Author: lev
Date: Wed Feb  3 20:35:25 UTC 2021
New revision: 563962
URL: https://svnweb.freebsd.org/changeset/ports/563962

Log:
   Fix incompatibility with KTLS.

  PR:		253214
  Submitted by:	madpilot@FreeBSD.org

Changes:
  head/www/serf/Makefile
  head/www/serf/files/patch-buckets_ssl__buckets.c
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2021-02-03 21:07:10 UTC 
Committed, thnx!
Comment 4 Jan Beich freebsd_committer freebsd_triage 2021-02-03 23:48:57 UTC 
Can you MFH to 2021Q1 as well? KTLS in base OpenSSL is scheduled for MFC to /stable/13 which uses /quarterly by default.
Comment 5 Lev A. Serebryakov freebsd_committer freebsd_triage 2021-02-04 09:51:42 UTC 
(In reply to Jan Beich from comment #4)
I'll try, though I never did it before.
Comment 6 Lev A. Serebryakov freebsd_committer freebsd_triage 2021-02-04 09:52:29 UTC 
Need to MFH to 2021Q1.
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-02-04 11:38:17 UTC 
A commit references this bug:

Author: lev
Date: Thu Feb  4 11:38:07 UTC 2021
New revision: 564018
URL: https://svnweb.freebsd.org/changeset/ports/564018

Log:
  MFH: r563962

   Fix incompatibility with KTLS.

  PR:		253214
  Submitted by:	madpilot@FreeBSD.org

  Approved by:	portmgr (blanket, FAQ 20.6.2)

Changes:
_U  branches/2021Q1/
  branches/2021Q1/www/serf/Makefile
  branches/2021Q1/www/serf/files/patch-buckets_ssl__buckets.c
Comment 8 Lev A. Serebryakov freebsd_committer freebsd_triage 2021-02-04 11:39:00 UTC 
Merged to 2021Q1