Bug 253251 - Hardware Revision Realtek 8117
Summary: Hardware Revision Realtek 8117
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.2-STABLE
Hardware: amd64 Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-04 16:04 UTC by Christian Gutzler
Modified: 2021-02-16 21:21 UTC (History)
2 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2021-02-11 20:42 UTC, Christian Gutzler 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Gutzler 2021-02-04 16:04:40 UTC 
My builtin Realtek 8117 is not attached (return 6) due to unknown HW revision / Chip rev. 0x54800000, Mac rev. 0x00200000.

As far as I understood, this seems to happen from time to time with new Realtek chips and the new HW ID maybe just needs to be included in the list.

I just added a photo of the screen, since I was sitting in front of it. Let me know if you need the output as text or anything else.

Greetings from Mannheim
Christian
Comment 1 Christian Gutzler 2021-02-11 20:42:28 UTC 
Created attachment 222373 [details]
Patch

My first patch ever, hope I did everything right.
Please review.

THX
Comment 2 Christian Gutzler 2021-02-11 20:44:01 UTC 
Comment on attachment 222373 [details]
Patch

My first patch ever. Hope I did everything right. Pls review. THX. Christian
Comment 3 Mark Johnston freebsd_committer 2021-02-12 17:35:58 UTC 
Hi, a couple of notes:
- the description string "8168H/8111H" is duplicated, it should probably be "8117"
- I think the RL_HWREV_8117 driver flags are probably close to RL_HWREV_8168EP.  The 8169 NICs are quite old.

Presumably the driver is basically functional with your patch applied?
Comment 4 Christian Gutzler 2021-02-16 21:21:25 UTC 
Hi,correct. It´s basically functional. Copied tha values from 0x54000000 assuming 0x54800000 would be a revision of this.

I´ll test with the changes proposed by you.