Bug 253265 - benchmarks/flamegraph: installs files into the same place as devel/p5-Devel-NYTProf
Summary: benchmarks/flamegraph: installs files into the same place as devel/p5-Devel-N...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-05 08:21 UTC by ice
Modified: 2021-02-09 06:42 UTC (History)
3 users (show)

See Also:
fernape: maintainer-feedback? (jmd)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ice 2021-02-05 08:21:20 UTC
Tries to install ${LOCALBASE}/bin/flamegraph.pl which is also installed by devel/p5-Devel-NYTProf.
Comment 1 Fernando Apesteguía freebsd_committer 2021-02-08 14:44:15 UTC
Thanks for reporting this.
Comment 2 Vladimir Timofeev 2021-02-09 06:42:39 UTC
I just looked at it. Seems like author of Devel::NYTProf just redistribute same script with module.
1. Devel::NYTProf (devel/p5-Devel-NYTProf): https://github.com/timbunce/devel-nytprof/blob/master/bin/flamegraph.pl (outdated)
2. flamegraph (benchmarks/flamegraph): https://github.com/brendangregg/FlameGraph/blob/master/flamegraph.pl

Because flamegraph.pl changes mostly in compatible way, I think it is possible to exclude installation of somewhat outdated flamegraph.pl from Devel::NYTProf and add dependency to original flamegraph port. But that needs to be tested at least (I mean Devel::NYTProf reporting don't breaks).

What do you think?