Bug 253286 - lang/gcc10 build tests for zstd and if successful requires zstd in package
Summary: lang/gcc10 build tests for zstd and if successful requires zstd in package
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-06 06:41 UTC by dewayne
Modified: 2021-02-28 07:24 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2021-02-06 06:41:43 UTC
If archivers/zstd has been installed, prior to building lang/gcc10 it will require zstd to be installed for proper operation.  It seems that lto uses zstd, and there is a dependency by 
/usr/local/libexec/gcc10/gcc/x86_64-portbld-freebsd12.2/10.2.0/cc1
...
        libzstd.so.1 => /usr/local/lib/libzstd.so.1 (0x298ea000)

We chanced upon this during testing when we (unusally) rebuilt gcc10 after our ports were installed.  (zstd is required in our env by dovecot and rsync) :/

To help gcc10 behave correctly I'd suggest either making zstd a requirement for gcc10 or, as we've done, add
--without-zstd
to 
CONFIGURE_ARGS

(dovecot uses LIB_DEPENDS=   libzstd.so:archivers/zstd.  Though unless zstd is trained, I can't see the benefit...?)

Gerald, Thanks for maintaining gcc and friends, over to you :)
Comment 1 Gerald Pfeifer freebsd_committer 2021-02-12 22:26:10 UTC
Thanks for the fine report.  I'll be tackling this starting from 
gcc11-devel over gcc10-devel down to gcc10 in the coming week or so.

Indeed I'm leaning to add --without-zstd to CONFIGURE_ARGS since the
added dependency hardly appears to be worth it.

> Gerald, Thanks for maintaining gcc and friends, over to you :)

You're very welcome! :)
Comment 2 commit-hook freebsd_committer 2021-02-15 11:18:03 UTC
A commit references this bug:

Author: gerald
Date: Mon Feb 15 11:17:31 UTC 2021
New revision: 565301
URL: https://svnweb.freebsd.org/changeset/ports/565301

Log:
  Update to the 20210214 snapshot of GCC 11.0.0.

  Explicitly build --without-zstd such that archivers/zstd isn't pulled
  in inadvertedly when present in the build system even though it is not
  an explicit dependency. [1]

  PR:		253286 [1]

Changes:
  head/lang/gcc11-devel/Makefile
Comment 3 commit-hook freebsd_committer 2021-02-18 21:30:35 UTC
A commit references this bug:

Author: gerald
Date: Thu Feb 18 21:30:13 UTC 2021
New revision: 565994
URL: https://svnweb.freebsd.org/changeset/ports/565994

Log:
  Update to the 20210213 snapshot of GCC 10.2.1.

  Back port part of r565301 | gerald | 2021-02-15 from lang/gcc11-devel:

    Explicitly build --without-zstd such that archivers/zstd isn't pulled
    in inadvertedly when present in the build system even though it is not
    an explicit dependency. [1]

  PR:		253286 [1]

Changes:
  head/lang/gcc10-devel/Makefile
  head/lang/gcc10-devel/distinfo
Comment 4 commit-hook freebsd_committer 2021-02-21 09:20:48 UTC
A commit references this bug:

Author: gerald
Date: Sun Feb 21 09:19:55 UTC 2021
New revision: 566211
URL: https://svnweb.freebsd.org/changeset/ports/566211

Log:
  Back port part of r565994 | gerald | 2021-02-18 from lang/gcc10-devel:

    Back port part of r565301 | gerald | 2021-02-15 from lang/gcc11-devel:

      Explicitly build --without-zstd such that archivers/zstd isn't pulled
      in inadvertedly when present in the build system even though it is not
      an explicit dependency. [1]

  PR:		253286 [1]

Changes:
  head/lang/gcc10/Makefile
Comment 5 Gerald Pfeifer freebsd_committer 2021-02-21 09:28:41 UTC
We have now ensured that future versions (like lang/gcc11 later this
year) have this addressed, as has GCC 10 (both -devel and regular)
which is our default in the tree and the target of this report.

I plan on making similar changes to gcc9-devel and gcc8-devel in the
coming days, and then gcc9 a bit later.

Thank you for the fine report!
Comment 6 commit-hook freebsd_committer 2021-02-22 13:17:21 UTC
A commit references this bug:

Author: gerald
Date: Mon Feb 22 13:16:20 UTC 2021
New revision: 566296
URL: https://svnweb.freebsd.org/changeset/ports/566296

Log:
  Update to the 20210219 snapshot of GCC 9.3.1.

  This only brings a minor tweak to the data flow engine.

  Plus a back port of part of r565301 | gerald | 2021-02-15 from
  lang/gcc11-devel:

    Explicitly build --without-zstd such that archivers/zstd isn't pulled
    in inadvertedly when present in the build system even though it is not
    an explicit dependency. [1]

  PR:		253286 [1]

Changes:
  head/lang/gcc9-devel/Makefile
  head/lang/gcc9-devel/distinfo
Comment 7 commit-hook freebsd_committer 2021-02-24 07:41:33 UTC
A commit references this bug:

Author: gerald
Date: Wed Feb 24 07:40:41 UTC 2021
New revision: 566453
URL: https://svnweb.freebsd.org/changeset/ports/566453

Log:
  Update to the 20210218 snapshot of GCC 8.4.1.

  ALso back port part of r565301 | gerald | 2021-02-15 from
  lang/gcc11-devel:

    Explicitly build --without-zstd such that archivers/zstd isn't pulled
    in inadvertedly when present in the build system even though it is not
    an explicit dependency. [1]

  PR:		253286 [1]

Changes:
  head/lang/gcc8-devel/Makefile
  head/lang/gcc8-devel/distinfo
Comment 8 commit-hook freebsd_committer 2021-02-27 07:47:00 UTC
A commit references this bug:

Author: gerald
Date: Sat Feb 27 07:46:03 UTC 2021
New revision: 566673
URL: https://svnweb.freebsd.org/changeset/ports/566673

Log:
  MFH: r565301 (partially)

  Explicitly build --without-zstd such that archivers/zstd isn't pulled
  in inadvertedly when present in the build system even though it is not
  an explicit dependency. [1]

  PR:		253286 [1]

Changes:
_U  branches/2021Q1/
  branches/2021Q1/lang/gcc11-devel/Makefile
Comment 9 commit-hook freebsd_committer 2021-02-27 08:00:04 UTC
A commit references this bug:

Author: gerald
Date: Sat Feb 27 07:59:28 UTC 2021
New revision: 566674
URL: https://svnweb.freebsd.org/changeset/ports/566674

Log:
  MFH: r565994 (partially)

  Back port part of r565301 | gerald | 2021-02-15 from lang/gcc11-devel:

    Explicitly build --without-zstd such that archivers/zstd isn't pulled
    in inadvertedly when present in the build system even though it is not
    an explicit dependency. [1]

  PR:		253286 [1]

Changes:
_U  branches/2021Q1/
  branches/2021Q1/lang/gcc10-devel/Makefile
Comment 10 commit-hook freebsd_committer 2021-02-27 08:22:09 UTC
A commit references this bug:

Author: gerald
Date: Sat Feb 27 08:21:48 UTC 2021
New revision: 566676
URL: https://svnweb.freebsd.org/changeset/ports/566676

Log:
  MFH: r566211

  Back port part of r565994 | gerald | 2021-02-18 from lang/gcc10-devel:

    Back port part of r565301 | gerald | 2021-02-15 from lang/gcc11-devel:

      Explicitly build --without-zstd such that archivers/zstd isn't pulled
      in inadvertedly when present in the build system even though it is not
      an explicit dependency. [1]

  PR:		253286 [1]

Changes:
_U  branches/2021Q1/
  branches/2021Q1/lang/gcc10/Makefile
Comment 11 commit-hook freebsd_committer 2021-02-28 07:22:30 UTC
A commit references this bug:

Author: gerald
Date: Sun Feb 28 07:21:44 UTC 2021
New revision: 566749
URL: https://svnweb.freebsd.org/changeset/ports/566749

Log:
  MFH: r566296 (partially)

  Plus a back port of part of r565301 | gerald | 2021-02-15 from
  lang/gcc11-devel:

    Explicitly build --without-zstd such that archivers/zstd isn't pulled
    in inadvertedly when present in the build system even though it is not
    an explicit dependency. [1]

  PR:		253286 [1]

Changes:
_U  branches/2021Q1/
  branches/2021Q1/lang/gcc9-devel/Makefile
Comment 12 commit-hook freebsd_committer 2021-02-28 07:24:33 UTC
A commit references this bug:

Author: gerald
Date: Sun Feb 28 07:24:04 UTC 2021
New revision: 566750
URL: https://svnweb.freebsd.org/changeset/ports/566750

Log:
  MFH: r566453 (partially)

  ALso back port part of r565301 | gerald | 2021-02-15 from
  lang/gcc11-devel:

    Explicitly build --without-zstd such that archivers/zstd isn't pulled
    in inadvertedly when present in the build system even though it is not
    an explicit dependency. [1]

  PR:		253286 [1]

Changes:
_U  branches/2021Q1/
  branches/2021Q1/lang/gcc8-devel/Makefile