Bug 253415 - graphics/opencv: add HARDENING and LTO options
Summary: graphics/opencv: add HARDENING and LTO options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias C. Berner
URL:
Keywords: feature, needs-qa, performance, security
Depends on:
Blocks:
 
Reported: 2021-02-10 20:52 UTC by Piotr Kubaj
Modified: 2021-02-11 18:00 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
patch (740 bytes, patch)
2021-02-10 20:52 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2021-02-10 20:52:27 UTC 
Created attachment 222341 [details]
patch

Those options enable respective build parameters.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-11 05:49:36 UTC 
Moin moin 

There is an other open PR  253110 which plans to reinstate all the other options too.

mfg Tobias
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-02-11 12:39:22 UTC 
A commit references this bug:

Author: pkubaj
Date: Thu Feb 11 12:38:26 UTC 2021
New revision: 564940
URL: https://svnweb.freebsd.org/changeset/ports/564940

Log:
  graphics/opencv: add HARDENING and LTO options

  PR:		253415
  Approved by:	tcberner (maintainer)

Changes:
  head/graphics/opencv/Makefile
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-11 15:31:16 UTC 
Moin moin

To clarify, there was no approval here, I was acknowledging the report, not accepting the change, otherwise, I would have set the 'approved' flag the patch.

"Maintainer Feedback +" is not the same as "Maintainer Approval +" on the patch :)



mfg Tobias
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2021-02-11 17:01:34 UTC 
(In reply to Tobias C. Berner from comment #3)
Sorry, I got them mixed.

Do you want me to revert the commit?
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-11 18:00:54 UTC 
No it's fine.

mfg Tobias