Bug 253434 - x11-toolkits/gtk30 unnecessary has build-dependency on v4l-compat for wayland
Summary: x11-toolkits/gtk30 unnecessary has build-dependency on v4l-compat for wayland
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-11 12:19 UTC by Oleh Vinichenko
Modified: 2021-02-12 20:49 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Vinichenko 2021-02-11 12:19:59 UTC 
As in Summary, gtk30, when WAYLAND OPTION is set, has v4l-compat build-time dependency. Nowhere in gtk's configure options this present, so this dependency likely can be removed. Please, review and fix, if possible.
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-12 20:12:13 UTC 
Moin moin 

I believe, the dependency was due to the input.h & co headers previously being part of that package. Nowadays, they are part of devel/evdev-proto -- so that dependency is indeed not necessary anymore.


mfg Tobias
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-12 20:49:19 UTC 
Committed. Thansk.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-12 20:49:26 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Feb 12 20:49:12 UTC 2021
New revision: 565064
URL: https://svnweb.freebsd.org/changeset/ports/565064

Log:
  x11-toolkits/gtk30: remnove  unnecessary dependency on multimedia/v4l_compat

  - The depednecy was previosuly there to get linux/input.h
  - However, with [1] gtk switched to using the shipped dev/evdev/input.h on FreeBSD.

  [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/7fed0b74ed9f

  PR:		253434
  Reported by:	Oleh Vinichenko <moonlapse81@gmail.com>

Changes:
  head/x11-toolkits/gtk30/Makefile