Bug 253465 - bsd.port.mk: Pass all relevant variables to dialog4ports
Summary: bsd.port.mk: Pass all relevant variables to dialog4ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Certner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-12 17:54 UTC by Olivier Certner
Modified: 2024-01-23 18:01 UTC (History)
0 users

See Also:

Attachments
Patch against the ports tree (545 bytes, patch)
2021-02-12 17:54 UTC, Olivier Certner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Certner freebsd_committer freebsd_triage 2021-02-12 17:54:40 UTC 
Created attachment 222395 [details]
Patch against the ports tree

Some environment variables described in dialog4ports(1) are not passed by the ports framework when specified as Make variables, contrary to other ones.

Missing ones list:
- D4PMINHEIGHT
- D4PALIGNCENTER
- D4PASCIILINES

Simple patch attached.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2021-02-26 19:06:14 UTC 
It's in, thanks
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-02-26 19:06:53 UTC 
A commit references this bug:

Author: bapt
Date: Fri Feb 26 19:06:01 UTC 2021
New revision: 566629
URL: https://svnweb.freebsd.org/changeset/ports/566629

Log:
  Pass all env variable supported by dialog4ports to
  the customer script that will run dialog4ports

  PR:		253465
  Submitted by:	Olivier Certner <olivier.freebsd@free.fr>

Changes:
  head/Mk/bsd.port.mk
Comment 3 Olivier Certner freebsd_committer freebsd_triage 2024-01-23 17:46:35 UTC 
Assign to the committer who resolved (bapt@).
Comment 4 Olivier Certner freebsd_committer freebsd_triage 2024-01-23 18:01:38 UTC 
Mmm, in fact, it was my patch.