Bug 253504 - audio/mixxx: Possible redudant dependencies
Summary: audio/mixxx: Possible redudant dependencies
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-14 13:37 UTC by Daniel Engberg
Modified: 2021-05-05 19:44 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg 2021-02-14 13:37:26 UTC
Having a look at the source code it looks like some dependencies could be dropped as they're handled by FFmpeg

libmad (and most likely libid3tag)
https://github.com/mixxxdj/mixxx/blob/release-2.2.4/src/sources/soundsourceffmpeg.cpp#L152

libogg + libvorbis
https://github.com/mixxxdj/mixxx/blob/release-2.2.4/src/sources/soundsourceffmpeg.cpp#L145
https://github.com/mixxxdj/mixxx/blob/release-2.2.4/src/encoder/encoderffmpegvorbis.cpp

Best regards,
Daniel
Comment 1 Daniel Engberg 2021-03-03 14:35:51 UTC
Ping
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer 2021-04-15 01:52:13 UTC
Hi Daniel

I see ffmpeg is optional feature and it extends support for some kind of audio files. Also it doesn't exclude vorbis/ogg support if I choose FFMPEG like an option (Take a look into Scons scripts).

Maybe I could make some changes to this port excluding ogg/vorbis and some another dependencies if FFMPEG option is selected. It it is not selected ogg/vorbis (and more) are included like depdendencies. It could be the best to do here. 

What do you think?
Comment 3 Daniel Engberg 2021-05-05 19:44:27 UTC
Hi,

Sorry for the late reply! I looked at it mainly to reduce the usage of libmad and libid3tag (dated, slow and unmaintained) and I happened to also spot libogg and libvorbis in there. It does look as you say that ogg/vorbis are more tightly integrated however so we probably need to leave that in.

Best regards,
Daniel