Bug 253507 - audio/moc: Improve user experience by depending on FFmpeg as default option
Summary: audio/moc: Improve user experience by depending on FFmpeg as default option
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-02-14 14:10 UTC by Daniel Engberg
Modified: 2021-06-06 23:02 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rob)


Attachments
Patch for moc (1.08 KB, patch)
2021-02-14 14:10 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer 2021-02-14 14:10:53 UTC
Created attachment 222436 [details]
Patch for moc

Instead of pulling in lib(flac) and libmad utilize ffmpeg which also supports a lot more formats and offers better performance overall.

Can't find a browsable online repo so I'll refer to the source code instead.
decoder_plugins/ffmpeg/ffmpeg.c L325 and below

Also utilize USES= localbase:ldflags instead setting it manually via CPP and LDFLAGS

Compile and runtime-tested on FreeBSD 13.0-BETA2 (amd64) (make, make check-plist)
Comment 1 Automation User 2021-03-01 00:51:09 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/263179086
Comment 2 Rob Zinkov 2021-03-01 01:42:40 UTC
Thanks!

I don't want to make ffmpeg a dependency by default. Also I think there is already an option to use ffmpeg so the better performance is there for those that want it.
Comment 3 Daniel Engberg freebsd_committer 2021-03-03 07:37:23 UTC
Any reason for this? It would be very nice if we could move away from abdandomware such as libmad, being abdandomware it's also hard(er) to keep track of security issues such as r517408

Regards,
Daniel
Comment 4 Rob Zinkov 2021-05-30 22:39:07 UTC
I want to close this issue, but I don't know how.
Comment 5 Daniel Engberg freebsd_committer 2021-05-31 05:33:14 UTC
It would  be nice however if you could elaborate a bit more for further reference.
Comment 6 Rob Zinkov 2021-06-06 21:04:58 UTC
I don't think the abandonware argument makes sense since moc itself has generally been unmaintained for an equally long while. It is a shame, since I do still use it daily.