Bug 253563 - Use '/usr/local/bin/python3' as the value of PYTHON_CMD
Summary: Use '/usr/local/bin/python3' as the value of PYTHON_CMD
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Ebdrup Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-16 18:10 UTC by Yasuhiro Kimura
Modified: 2021-02-16 18:50 UTC (History)
1 user (show)

See Also:


Attachments
Patch file (1.55 KB, patch)
2021-02-16 18:10 UTC, Yasuhiro Kimura
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura 2021-02-16 18:10:04 UTC
Created attachment 222495 [details]
Patch file

Currently '/usr/local/bin/python3.7' is used as the value of PYTHON_CMD. Right now it is proper because 3.7 is the default version of Python 3 in ports tree. But it will be change to newer version in the future. Additionally, if user build packages from ports tree by himself he can change default version of Python 3 by adding 'DEFAULT_VERSIONS+=python3=3.x' in make.conf. In such cases setting PYTHON_CMD to '/usr/local/bin/python3.7' is improper.

BTW in the section 1.1 of FDP user is told to install 'python3' package. This is meta package that depends on the default version of Python 3. And if it is installed '/usr/local/bin/python3' is created as the symbolic link to the Python 3 interpreter of the default version (e.g. /usr/local/bin/python3.7). So if '/usr/local/bin/python3' is used as the value of PYTHON_CMD, it works fine regardless of which version is assigned to the default of Python 3.

So change the value of PYTHON_CMD in doc tree to '/usr/local/bin/python3'.
Comment 1 Daniel Ebdrup Jensen freebsd_committer 2021-02-16 18:28:48 UTC
I'll take this.

Are you okay with being credited with `git commit --author="Yasuhiro Kimura <yasu@utahime.org>" ?
Comment 2 Daniel Ebdrup Jensen freebsd_committer 2021-02-16 18:50:37 UTC
Ah, I see that you've already got plenty of ports under your email, so I take it it's fine to use it. :)

This landed as https://cgit.freebsd.org/doc/commit/?id=8750cad4505afa3e6a21d2b52d89a8f6ab58a131