Bug 253588 - java/openjdk8: replace ECHO with ECHO_CMD in Makefile
Summary: java/openjdk8: replace ECHO with ECHO_CMD in Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-17 14:50 UTC by Michael Muenz
Modified: 2021-02-19 08:06 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (java)


Attachments
ECHO_CMD patch (1.08 KB, patch)
2021-02-17 14:50 UTC, Michael Muenz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Muenz 2021-02-17 14:50:41 UTC
Created attachment 222528 [details]
ECHO_CMD patch

Hi,

when building via ports (not poudriere) it breaks building at dependency devel/sbt since it doesn't know where java is.

Replacing the simple ECHO with the standard ECHO_CMD fixes it.

Best,
Michael
Comment 1 Franco Fichtner 2021-02-17 14:53:29 UTC
The problem actually is that when using "make -s" ECHO builtin is cleared and the vital port parts are not added... ECHO should not be used in Makefiles unless it is a verbose message.


Cheers,
Franco
Comment 2 Jung-uk Kim freebsd_committer 2021-02-19 07:57:22 UTC
I'll take it.
Comment 3 commit-hook freebsd_committer 2021-02-19 08:02:55 UTC
A commit references this bug:

Author: jkim
Date: Fri Feb 19 08:02:02 UTC 2021
New revision: 566035
URL: https://svnweb.freebsd.org/changeset/ports/566035

Log:
  Replace ${ECHO} with ${ECHO_CMD}.

  ${ECHO} may be no-op when "make -s" is used.

  PR:		253588

Changes:
  head/java/openjdk8/Makefile
Comment 4 Jung-uk Kim freebsd_committer 2021-02-19 08:06:13 UTC
Committed, thanks!