Bug 253594 - databases/postgis30 missing shp2pgsql/pgsql2shp
Summary: databases/postgis30 missing shp2pgsql/pgsql2shp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-17 18:24 UTC by Thomas Skowron
Modified: 2022-01-06 16:28 UTC (History)
0 users

See Also:
lbartoletti: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Skowron 2021-02-17 18:24:57 UTC
The tools are built and placed in $STAGE/$PREFIX/bin/shp2pgsql..., but they're not being installed as far as I can see.

Could this be because they're incorrectly prefixed with %%LOADERGUI%% as should be necessary for shp2pgsql-gui, but not for shp2pgsql itself?
Comment 1 Thomas Skowron 2021-02-17 18:27:42 UTC
Same for database/postgis31, but not for database/postgis25 and lower as far as I see.
Comment 2 Thomas Skowron 2021-03-14 14:25:08 UTC
Any chance to get this patched?
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2021-06-18 06:45:22 UTC
(In reply to Thomas Skowron from comment #2)

IIRC, shp2pgsql and shp2pgsql-gui are not separated now. I'll look into it in the next few weeks. Have you tried to build it without gtk?
Comment 4 Loïc Bartoletti freebsd_committer freebsd_triage 2022-01-06 15:49:26 UTC
(In reply to Loïc Bartoletti from comment #3)
I was wrong... sorry. There is a typo in the pkg-plist, and you're right they're incorrectly prefixed with %%LOADERGUI%%

I'll fix it very quickly
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-01-06 15:52:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0f94ea174e3e85c80388fbf1b28abce4d75b7b05

commit 0f94ea174e3e85c80388fbf1b28abce4d75b7b05
Author:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
AuthorDate: 2022-01-06 14:50:03 +0000
Commit:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
CommitDate: 2022-01-06 14:51:34 +0000

    databases/postgis3*: fix pkg-plist

    bin/shp2pgsql and bin/pgsql2shp were incorrectly prefixed with %%LOADERGUI%%
    PR:             253594
    Reported by:    Thomas Skowron <th@skowron.eu>

 databases/postgis30/Makefile  | 2 +-
 databases/postgis30/pkg-plist | 4 ++--
 databases/postgis31/Makefile  | 2 +-
 databases/postgis31/pkg-plist | 4 ++--
 databases/postgis32/Makefile  | 1 +
 databases/postgis32/pkg-plist | 4 ++--
 6 files changed, 9 insertions(+), 8 deletions(-)
Comment 6 Loïc Bartoletti freebsd_committer freebsd_triage 2022-01-06 16:28:45 UTC
Thanks and sorry.