Bug 253684 - math/openblas: replace ECHO with ECHO_CMD
Summary: math/openblas: replace ECHO with ECHO_CMD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-19 08:43 UTC by Michael Muenz
Modified: 2021-04-17 13:52 UTC (History)
2 users (show)

See Also:
phd_kimberlite: maintainer-feedback+


Attachments
openblas ECHO patcg (1.83 KB, patch)
2021-02-19 08:43 UTC, Michael Muenz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Muenz 2021-02-19 08:43:20 UTC
Created attachment 222627 [details]
openblas ECHO patcg

Hi,

Use of ECHO in Makefile will break usage of "make -s".
Similar to this: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253588
It breaks my ports-build for opencv.

Thanks,
Michael
Comment 1 commit-hook freebsd_committer 2021-04-17 13:51:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9d142bc1d25b9c7295d04cb114fc7e786941b2f0

commit 9d142bc1d25b9c7295d04cb114fc7e786941b2f0
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-04-17 13:49:36 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-04-17 13:50:00 +0000

    Replace ${ECHO} with ${ECHO_CMD}, ECHO builtin is cleared with ``make -s''

    PR:     253684

 math/openblas/Makefile | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer 2021-04-17 13:52:58 UTC
Committed, thanks!