Bug 253719 - graphics/digikam: Fix mediaplayer support
Summary: graphics/digikam: Fix mediaplayer support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-20 12:45 UTC by Gregor Kopf
Modified: 2021-02-22 15:35 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
Patch for enabling mediaplayer support (408 bytes, patch)
2021-02-20 12:45 UTC, Gregor Kopf
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Kopf 2021-02-20 12:45:26 UTC
Created attachment 222669 [details]
Patch for enabling mediaplayer support

Hi,

when enabling the the MEDIAPLAYER port option, it appears that the ENABLE_MEDIAPLAYER CMAKE flag is not set. This causes digikam to be built without mediaplayer support. The attached patch fixes that.

Would it be worth including it?

Cheers,
greg
Comment 1 Tobias C. Berner freebsd_committer 2021-02-20 13:17:42 UTC
Moin moin

Good catch, thank you very much. I'll fix it shortly.


mfg Tobias
Comment 2 commit-hook freebsd_committer 2021-02-20 15:30:55 UTC
A commit references this bug:

Author: tcberner
Date: Sat Feb 20 15:30:51 UTC 2021
New revision: 566163
URL: https://svnweb.freebsd.org/changeset/ports/566163

Log:
  graphics/digikam: fix MEDIAPLAYER option

  PR:		253719
  Submitted by:	Gregor Kopf <freebsd@gregorkopf.de>

Changes:
  head/graphics/digikam/Makefile
  head/graphics/digikam/pkg-plist
Comment 3 Adriaan de Groot freebsd_committer 2021-02-22 15:35:18 UTC
Landed presumed fixed