Bug 253722 - games/freeblocks: fix build on FreeBSD 13+
Summary: games/freeblocks: fix build on FreeBSD 13+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-20 15:20 UTC by Christian Weisgerber
Modified: 2021-02-25 15:00 UTC (History)
0 users

See Also:
amdmi3: maintainer-feedback+


Attachments
freeblocks.patch (12.34 KB, patch)
2021-02-20 15:20 UTC, Christian Weisgerber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weisgerber freebsd_committer 2021-02-20 15:20:43 UTC
Created attachment 222678 [details]
freeblocks.patch

games/freeblocks fails to build on FreeBSD 13+ due to the new -fno-common default in LLVM11.

The attached patch fixes the variable declarations, so the port will build with LLVM11 and GCC10.
Comment 1 Dmitry Marakasov freebsd_committer 2021-02-25 00:42:34 UTC
LGTM, please commit
Comment 2 commit-hook freebsd_committer 2021-02-25 14:58:56 UTC
A commit references this bug:

Author: naddy
Date: Thu Feb 25 14:58:05 UTC 2021
New revision: 566539
URL: https://svnweb.freebsd.org/changeset/ports/566539

Log:
  games/freeblocks: fix build on FreeBSD 13/14

  This fixes the variable declarations so the port will build with
  LLVM11's and GCC10's default of -fno-common.

  PR:		253722
  Approved by:	amdmi3

Changes:
  head/games/freeblocks/Makefile
  head/games/freeblocks/files/patch-src_block.c
  head/games/freeblocks/files/patch-src_block.h
  head/games/freeblocks/files/patch-src_game.c
  head/games/freeblocks/files/patch-src_game.h
  head/games/freeblocks/files/patch-src_menu.h
  head/games/freeblocks/files/patch-src_sys.c
  head/games/freeblocks/files/patch-src_sys.h